Refactor Python interpreter/Julia executable discovery #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolve_python_interpreter() has now been refactored into two functions: resolve_current_python_interpreter() returns the current Python executable while resolve_python_interpreter() returns returns the interpreter set in application settings. Re spine-tools/Spine-Toolbox#2446
resolve_julia_executable() has now been refactored into two functions: resolve_default_julia_executable() returns the Julia executable from PATH and resolve_julia_executable() returns returns the executable set in application settings. Re spine-tools/Spine-Toolbox#2446
soininen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks
resolve_python_interpreter()andresolve_julia_executable()functions into two: one returns the system's default executable (from PATH) and one that returns the executable from application settings (falling back to PATH, if not found).This lays groundwork for further changes in Spine Toolbox and spine-items.
Re spine-tools/Spine-Toolbox#2446
Checklist before merging