Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importer fewer columns than expected Traceback #160

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

PiispaH
Copy link
Collaborator

@PiispaH PiispaH commented Oct 5, 2023

Now when an importer spec is modified to have a column reference that is out of range for the source data, an error is shown. If such importer spec is executed an error will also be thrown and logged.

Fixes spine-tools/Spine-Toolbox#2333

Checklist before merging

  • Documentation (also in Toolbox repo) is up-to-date
  • Release notes in Toolbox repo have been updated
  • Unit tests have been added/updated accordingly
  • Code has been formatted by black
  • Unit tests pass

Now when an importer spec is modified to have a column
reference that is out of range for the source data, an
error is shown. If such importer spec is executed an
error will also be thrown and logged.

Re spine-tools/Spine-Toolbox#2333
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (90c8780) 55.46% compared to head (d1e89da) 55.43%.
Report is 1 commits behind head on 0.8-dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           0.8-dev     #160      +/-   ##
===========================================
- Coverage    55.46%   55.43%   -0.03%     
===========================================
  Files          192      192              
  Lines        17286    17306      +20     
  Branches      2829     2832       +3     
===========================================
+ Hits          9587     9593       +6     
- Misses        7179     7192      +13     
- Partials       520      521       +1     
Files Coverage Δ
spine_items/importer/mvcmodels/mappings_model.py 53.49% <25.00%> (-0.15%) ⬇️
spine_items/importer/widgets/import_sources.py 54.34% <36.84%> (-1.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PiispaH PiispaH merged commit 53945d0 into 0.8-dev Oct 5, 2023
8 checks passed
@PiispaH PiispaH deleted the issue_2333_importer_table_size_change branch October 5, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants