Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lambda): cache state and state reason info for lambda functions #5402

Merged
merged 1 commit into from
Jun 25, 2021
Merged

fix(lambda): cache state and state reason info for lambda functions #5402

merged 1 commit into from
Jun 25, 2021

Conversation

nimakaviani
Copy link
Member

the state can be used to determine whether a lambda function is ready
to receive traffic.

@nimakaviani nimakaviani mentioned this pull request Jun 24, 2021
Merged
zachsmith1
zachsmith1 approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@zachsmith1 zachsmith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani
fix(lambda): cache state and state reason info for lambda functions
6604839 
the state can be used to determine whether a lambda function is ready
to receive traffic.
@nimakaviani
Copy link
Member Author

thanks for catching the duplication @zachsmith1 ... much simpler fix now.

zachsmith1
zachsmith1 approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@zachsmith1 zachsmith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachsmith1 zachsmith1 added the ready to merge Approved and ready for a merge label Jun 25, 2021
@mergify mergify bot merged commit 39de791 into spinnaker:master Jun 25, 2021
@mergify mergify bot added the auto merged Merged automatically by a bot label Jun 25, 2021
@zachsmith1
Copy link
Contributor

@Mergifyio backport release-1.26.x, release-1.25.x, release-1.25.x

mergify bot pushed a commit that referenced this pull request Jun 25, 2021
@nimakaviani
fix(lambda): cache state and state reason info for lambda functions (#…
b95ccad 
…5402)

the state can be used to determine whether a lambda function is ready
to receive traffic.

(cherry picked from commit 39de791)
@mergify mergify bot mentioned this pull request Jun 25, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2021

Command backport release-1.26.x, release-1.25.x, release-1.25.x: failure

No backport have been created

@zachsmith1
Copy link
Contributor

@Mergifyio backport release-1.26.x release-1.24.x

mergify bot pushed a commit that referenced this pull request Jun 25, 2021
@nimakaviani
fix(lambda): cache state and state reason info for lambda functions (#…
0eabc4c 
…5402)

the state can be used to determine whether a lambda function is ready
to receive traffic.

(cherry picked from commit 39de791)
@mergify mergify bot mentioned this pull request Jun 25, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jun 25, 2021
@nimakaviani
fix(lambda): cache state and state reason info for lambda functions (#…
55bd549 
…5402)

the state can be used to determine whether a lambda function is ready
to receive traffic.

(cherry picked from commit 39de791)
@mergify mergify bot mentioned this pull request Jun 25, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Jun 25, 2021

Command backport release-1.26.x release-1.24.x: success

Backports have been created

@link108 link108 added the backport-candidate Add to PRs to designate release branch patch candidates. label Jun 25, 2021
mergify bot added a commit that referenced this pull request Jun 25, 2021
@mergify @nimakaviani
fix(lambda): cache state and state reason info for lambda functions (#…
c7ee9cd 
…5402) (#5403)

the state can be used to determine whether a lambda function is ready
to receive traffic.

(cherry picked from commit 39de791)

Co-authored-by: Nima Kaviani <17132353+nimakaviani@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jun 25, 2021
@mergify @nimakaviani
fix(lambda): cache state and state reason info for lambda functions (#…
4801f1b 
…5402) (#5404)

the state can be used to determine whether a lambda function is ready
to receive traffic.

(cherry picked from commit 39de791)

Co-authored-by: Nima Kaviani <17132353+nimakaviani@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jun 25, 2021
@mergify @nimakaviani
fix(lambda): cache state and state reason info for lambda functions (#…
1aa8a83 
…5402) (#5405)

the state can be used to determine whether a lambda function is ready
to receive traffic.

(cherry picked from commit 39de791)

Co-authored-by: Nima Kaviani <17132353+nimakaviani@users.noreply.github.com>
@link108 link108 removed the backport-candidate Add to PRs to designate release branch patch candidates. label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachsmith1 zachsmith1 zachsmith1 approved these changes

Assignees
No one assigned
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.27
Projects
None yet
Milestone
No milestone
4 participants
@nimakaviani @zachsmith1 @link108 @spinnakerbot