Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appengine): Checks destination directory before unpacking file. #5443

Merged
merged 7 commits into from
Jul 28, 2021

Conversation

rvazquezglez
Copy link
Contributor

fix(appengine): Checks destination directory before unpacking file.

@zachsmith1 zachsmith1 marked this pull request as ready for review July 28, 2021 17:20
@zachsmith1 zachsmith1 self-requested a review as a code owner July 28, 2021 17:20
Copy link
Contributor

@zachsmith1 zachsmith1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachsmith1 zachsmith1 added the ready to merge Approved and ready for a merge label Jul 28, 2021
@mergify mergify bot added the auto merged Merged automatically by a bot label Jul 28, 2021
@mergify mergify bot merged commit 61d6b30 into spinnaker:master Jul 28, 2021
@link108
Copy link
Member

link108 commented Aug 4, 2021

@Mergifyio backport release-1.24.x release-1.25.x release-1.26.x

mergify bot pushed a commit that referenced this pull request Aug 4, 2021
…5443)

* fix(appengine): Checks destination directory before unpacking file.

* fix(appengine): Removes reference to FileUtils

* fix(appengine): Uses crafted `tar` file to trigger vulnerability on tests and check it throws an exception preventing further damage.

* fix(appengine): Removes zip file.

* fix(appengine): Adds happy path test.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 61d6b30)
mergify bot pushed a commit that referenced this pull request Aug 4, 2021
…5443)

* fix(appengine): Checks destination directory before unpacking file.

* fix(appengine): Removes reference to FileUtils

* fix(appengine): Uses crafted `tar` file to trigger vulnerability on tests and check it throws an exception preventing further damage.

* fix(appengine): Removes zip file.

* fix(appengine): Adds happy path test.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 61d6b30)
mergify bot pushed a commit that referenced this pull request Aug 4, 2021
…5443)

* fix(appengine): Checks destination directory before unpacking file.

* fix(appengine): Removes reference to FileUtils

* fix(appengine): Uses crafted `tar` file to trigger vulnerability on tests and check it throws an exception preventing further damage.

* fix(appengine): Removes zip file.

* fix(appengine): Adds happy path test.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 61d6b30)
@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2021

Command backport release-1.24.x release-1.25.x release-1.26.x: success

Backports have been created

mergify bot added a commit that referenced this pull request Aug 17, 2021
…5443) (#5465)

* fix(appengine): Checks destination directory before unpacking file.

* fix(appengine): Removes reference to FileUtils

* fix(appengine): Uses crafted `tar` file to trigger vulnerability on tests and check it throws an exception preventing further damage.

* fix(appengine): Removes zip file.

* fix(appengine): Adds happy path test.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 61d6b30)

Co-authored-by: Raúl Vázquez <raul.vazquez@armory.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge target-release/1.27
Projects
None yet
4 participants