fix(core): fix vertical alignment of radio buttons (#7344)

* fix(core): fix vertical alignment of radio buttons * fix(kubernetes): make all kubernetes v2 stages use vertically aligned radio buttons
spinnaker · Aug 19, 2019 · 8bdca89 · 8bdca89
1 parent d00f2a4
commit 8bdca89
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 9 deletions.
diff --git a/app/scripts/modules/core/src/presentation/forms/inputs/RadioButtonInput.tsx b/app/scripts/modules/core/src/presentation/forms/inputs/RadioButtonInput.tsx
@@ -36,12 +36,10 @@ export const RadioButtonInput = (props: IRadioButtonInputProps) => {
   );
 
   const VerticalRadioButtons = ({ opts }: { opts: IRadioButtonOptions[] }) => (
-    <div className="vertical left">
-      <div className={elementClassName}>
-        {opts.map(option => (
-          <RadioButton key={option.label} option={option} />
-        ))}
-      </div>
+    <div className={`${elementClassName} vertical left`}>
+      {opts.map(option => (
+        <RadioButton key={option.label} option={option} />
+      ))}
     </div>
   );
 

diff --git a/...pts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/DeployManifestStageForm.tsx b/...pts/modules/kubernetes/src/v2/pipelines/stages/deployManifest/DeployManifestStageForm.tsx
@@ -148,7 +148,6 @@ export class DeployManifestStageForm extends React.Component<
         <h4>Manifest Configuration</h4>
         <StageConfigField label="Manifest Source" helpKey="kubernetes.manifest.source">
           <RadioButtonInput
-            inline={true}
             options={this.getSourceOptions()}
             onChange={(e: any) => this.props.formik.setFieldValue('source', e.target.value)}
             value={stage.source}

diff --git a/...ripts/modules/kubernetes/src/v2/pipelines/stages/patchManifest/PatchManifestStageForm.tsx b/...ripts/modules/kubernetes/src/v2/pipelines/stages/patchManifest/PatchManifestStageForm.tsx
@@ -115,7 +115,6 @@ export class PatchManifestStageForm extends React.Component<
             options={this.getSourceOptions()}
             onChange={(e: any) => this.props.formik.setFieldValue('source', e.target.value)}
             value={stage.source || 'text'}
-            inline={true}
           />
         </StageConfigField>
         {stage.source === this.textSource && (

diff --git a/...ripts/modules/kubernetes/src/v2/pipelines/stages/runJob/KubernetesV2RunJobStageConfig.tsx b/...ripts/modules/kubernetes/src/v2/pipelines/stages/runJob/KubernetesV2RunJobStageConfig.tsx
@@ -230,7 +230,6 @@ export class KubernetesV2RunJobStageConfig extends React.Component<IStageConfigP
         <h4>Manifest Configuration</h4>
         <StageConfigField label="Manifest Source" helpKey="kubernetes.manifest.source">
           <RadioButtonInput
-            inline={true}
             options={this.getSourceOptions()}
             onChange={(e: any) => this.props.updateStageField({ source: e.target.value })}
             value={stage.source}