feat(ecs): Add support for ECS deployment circuit breaker #10076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first contribution, and I tried to implement spinnaker/spinnaker#6225
This change comes together with this PR from clouddriver: spinnaker/clouddriver#6132
It implements a new checkbox to activate ECS Deployment Circuit Breaker for the ECS service; the default is false to not change any existing behavior.
The checkbox looks like this. I thought it should go under "Advanced settings".
If enabled, it adds the attribute
enabledDeploymentCircuitBreaker
to the server group:Running the Deploy stage will create an ECS service with Deployment Circuit Breaker enabled:
I'm open for your comments and your thoughts, also on the implementation - I mainly "mimicked" how other attributes/feature were implemented and tried my best "copy/pasting". 😏