Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): Add support for ECS deployment circuit breaker #10076

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

jgrumboe
Copy link
Contributor

@jgrumboe jgrumboe commented Jan 7, 2024

This is my first contribution, and I tried to implement spinnaker/spinnaker#6225

This change comes together with this PR from clouddriver: spinnaker/clouddriver#6132

It implements a new checkbox to activate ECS Deployment Circuit Breaker for the ECS service; the default is false to not change any existing behavior.

The checkbox looks like this. I thought it should go under "Advanced settings".
image

If enabled, it adds the attribute enabledDeploymentCircuitBreaker to the server group:
image

Running the Deploy stage will create an ECS service with Deployment Circuit Breaker enabled:
image

I'm open for your comments and your thoughts, also on the implementation - I mainly "mimicked" how other attributes/feature were implemented and tried my best "copy/pasting". 😏

Copy link
Contributor

@ovidiupopa07 ovidiupopa07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would switch between the checkbox and the text to have the same experience as for the other fields but it looks ok.

@jgrumboe
Copy link
Contributor Author

LGTM. I would switch between the checkbox and the text to have the same experience as for the other fields but it looks ok.

Good point. I copied it from somewhere.
I will switch it. So the checkbox should be aligned with the text input boxes above, right?

@ovidiupopa07
Copy link
Contributor

LGTM. I would switch between the checkbox and the text to have the same experience as for the other fields but it looks ok.

Good point. I copied it from somewhere. I will switch it. So the checkbox should be aligned with the text input boxes above, right?

Yes, I think it would look better 👍

@jgrumboe
Copy link
Contributor Author

@ovidiupopa07
It looks like this now, much cleaner.

@ovidiupopa07 ovidiupopa07 added the ready to merge Reviewed and ready for merge label Jan 17, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Jan 17, 2024
@mergify mergify bot merged commit 32dfea8 into spinnaker:master Jan 17, 2024
4 checks passed
@jgrumboe jgrumboe deleted the ecs-circuit-breaker branch January 18, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.34
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants