feat(provider/kubernetes): Deploy baked docker images #3588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
reviewed
Apr 26, 2017
| @@ -137,8 +137,10 @@ module.exports = angular.module('spinnaker.kubernetes.clusterCommandBuilder.serv | |||
| } | |||
|
|
|||
| function buildImageId(image) { | |||
| if (image.fromContext) { | |||
| if (image.fromContext && image.pattern && image.cluster) { | |||
There was a problem hiding this comment.
Does this mean it came from a findImage? I think we should be more explicit here
There was a problem hiding this comment.
e.g.
if (image.fromContext) {
if (image.fromBake) {
} else if (image.fromFindImage) {
} else {
// uh oh
}
} else if (image.fromTrigger && !image.tag) {
}There was a problem hiding this comment.
Yeah it's meant to cover the findImage case. I agree, it's good to be clear here.
| repository: current.ami_name, | ||
| organization: current.organization, | ||
| stageId: current.refId, | ||
| registry: 'containers.schibsted.io' |
There was a problem hiding this comment.
Is this meant to be hardcoded here?
There was a problem hiding this comment.
Oh, no that was me testing. I'll get that out 👍
|
Also could you double check this for me @danielpeach? |
danielpeach
approved these changes
Apr 26, 2017
brujoand
force-pushed
the
add_support_for_deploying_baked_docker_image
branch
from
cf73763
to
b4d043a
Compare
|
Thanks guys, I've addressed the comments and gotten back in sync with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The objective here is to be able to deploy baked docker containers to Kubernetes, so we don't have to rely on using the docker registry trigger, and we get to keep the traceability.
I haven't synced with anyone on this approach, so I expect to have to alter worthing and/or some of the flow for this. So feel free to make suggestions for change.
This PR depends on a change to orca: spinnaker/orca#1299