-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(provider/oracle): create/delete LoadBalancer #5868
feat(provider/oracle): create/delete LoadBalancer #5868
Conversation
db65a06
to
0c6a894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
36ab307
to
aa36f49
Compare
@spinnaker/reviewers related PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good.
- Please do not introduce new
.js
files (only.ts
). - I'm assuming you already know this, but we are migrating deck to use React. We are making an effort to support AngularJS views, but going forward, only React UIs will have first class support. This doesn't mean the PR has to be rewritten, but we do view these UI components as "legacy". At some point in the future, deck may stop supporting AngularJS views altogether.
hostnames?: IOracleHostname[]; | ||
backendSets?: { [name: string]: IOracleBackEndSet }; // not required to create LB, but useless without it | ||
freeformTags?: { [tagName: string]: string }; | ||
loadBalancerType?: string; // is this needed because it is there in ILoadBalancer but not ILoadBalancerUpsertCommand?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure of the answer to this question. @jrsquared might know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added (incorrectly to core) because of amazon load balancers, shouldn't be needed in oracle.
@@ -0,0 +1,157 @@ | |||
'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure this was cloned from an existing spec, but Typescript doesn't need 'use strict'
@@ -0,0 +1,456 @@ | |||
'use strict'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
app/scripts/modules/oracle/src/loadBalancer/configure/createLoadBalancer.controller.ts
Outdated
Show resolved
Hide resolved
app/scripts/modules/oracle/src/loadBalancer/configure/createLoadBalancer.controller.ts
Show resolved
Hide resolved
app/scripts/modules/oracle/src/loadBalancer/details/loadBalancerDetail.controller.js
Outdated
Show resolved
Hide resolved
app/scripts/modules/oracle/src/loadBalancer/loadBalancer.transformer.ts
Outdated
Show resolved
Hide resolved
app/scripts/modules/oracle/src/loadBalancer/loadBalancer.transformer.ts
Outdated
Show resolved
Hide resolved
000ff1b
to
9cf4511
Compare
Thanks for making those changes. lgtm |
Sorry, I forgot about this. I'll merge this today |
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (spinnaker#6861) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) 0cdcb1e fix(bake/oracle): Added extendedAttributes (spinnaker#6627) 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase a8c1749 chore(package): Just Update Prettier™ 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() ca71ab6 fix(oracle/pipeline): Rename ng module to spinnaker.oracle.* (spinnaker#6219) 6b8188b chore(*): Add core alias to module tsconfigs af292f6 fix(imports): Avoid "import { thing } from 'core'" d1acd1b fix(provider/oracle): fix update/edit LoadBalancer (spinnaker#6043) 72e1e8d fix(provider/oracle): add ssh key (spinnaker#5901) 2f3ca8d feat(provider/oracle): create/delete LoadBalancer (spinnaker#5868) 55987ec fix(bake): Execution details Rebake was always false when force rebaking a74a7f3 fix(bakery/oracle): use read-only text field for bake region (spinnaker#5843)
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (#6861) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802) e2b4d8e refactor(*): remove unused local storage caches (#6665) 0cdcb1e fix(bake/oracle): Added extendedAttributes (#6627) 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase a8c1749 chore(package): Just Update Prettier™ 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() ca71ab6 fix(oracle/pipeline): Rename ng module to spinnaker.oracle.* (#6219) 6b8188b chore(*): Add core alias to module tsconfigs af292f6 fix(imports): Avoid "import { thing } from 'core'" d1acd1b fix(provider/oracle): fix update/edit LoadBalancer (#6043) 72e1e8d fix(provider/oracle): add ssh key (#5901) 2f3ca8d feat(provider/oracle): create/delete LoadBalancer (#5868) 55987ec fix(bake): Execution details Rebake was always false when force rebaking a74a7f3 fix(bakery/oracle): use read-only text field for bake region (#5843)
Add create and delete LoadBalancer.
Allow createServerGroup to select a LoadBalancer.