-
Notifications
You must be signed in to change notification settings - Fork 902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bakery/oracle): use read-only text field for bake region #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoyongzhang
force-pushed
the
oracle_bakery
branch
from
October 10, 2018 13:38
2f03713
to
b60188b
Compare
guoyongzhang
force-pushed
the
oracle_bakery
branch
from
October 10, 2018 13:41
b60188b
to
f7aa54a
Compare
jrsquared
approved these changes
Oct 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
gcomstock
pushed a commit
to gcomstock/deck
that referenced
this pull request
Dec 3, 2018
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jun 5, 2019
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (spinnaker#6861) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802) e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665) 0cdcb1e fix(bake/oracle): Added extendedAttributes (spinnaker#6627) 7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase a8c1749 chore(package): Just Update Prettier™ 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() ca71ab6 fix(oracle/pipeline): Rename ng module to spinnaker.oracle.* (spinnaker#6219) 6b8188b chore(*): Add core alias to module tsconfigs af292f6 fix(imports): Avoid "import { thing } from 'core'" d1acd1b fix(provider/oracle): fix update/edit LoadBalancer (spinnaker#6043) 72e1e8d fix(provider/oracle): add ssh key (spinnaker#5901) 2f3ca8d feat(provider/oracle): create/delete LoadBalancer (spinnaker#5868) 55987ec fix(bake): Execution details Rebake was always false when force rebaking a74a7f3 fix(bakery/oracle): use read-only text field for bake region (spinnaker#5843)
christopherthielen
added a commit
that referenced
this pull request
Jun 5, 2019
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (#6861) 72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802) e2b4d8e refactor(*): remove unused local storage caches (#6665) 0cdcb1e fix(bake/oracle): Added extendedAttributes (#6627) 7d5fc34 chore(prettier): Just Use Prettier™ (#6600) cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation b6bab1e chore(prettier): Just Use Prettier™ f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase a8c1749 chore(package): Just Update Prettier™ 5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()' 0451046 chore(package): Add .npmignore to all packages 6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment) 35be1f0 refactor(*): Don't use js or ts file extension in require() ca71ab6 fix(oracle/pipeline): Rename ng module to spinnaker.oracle.* (#6219) 6b8188b chore(*): Add core alias to module tsconfigs af292f6 fix(imports): Avoid "import { thing } from 'core'" d1acd1b fix(provider/oracle): fix update/edit LoadBalancer (#6043) 72e1e8d fix(provider/oracle): add ssh key (#5901) 2f3ca8d feat(provider/oracle): create/delete LoadBalancer (#5868) 55987ec fix(bake): Execution details Rebake was always false when force rebaking a74a7f3 fix(bakery/oracle): use read-only text field for bake region (#5843)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use read-only text field for region instead of select field in Oracle Bake Configuration. Note that in oracle provider, there is only one region per account.