Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(*): remove unused local storage caches #6665

Merged
merged 1 commit into from
Mar 12, 2019
Merged

refactor(*): remove unused local storage caches #6665

merged 1 commit into from
Mar 12, 2019

Conversation

anotherchrisberry
Copy link
Contributor

Backend performance has improved pretty dramatically since the Spinnaker project started over four years ago. Many calls that were very slow and fairly expensive then no longer are, and things we used to cache in local storage don't really need to be.

Some of those entities (load balancers, instance types) are things we haven't cached for over a year. Some of them are actually pretty small or come back really quickly (VPCs/networks, subnets), so we really don't need to cache them.

Some things (really just applications) we used to cache because they were the landing page, but now search is the default landing page - and the applications list can be really big, so we shouldn't call it unless we need the data IMO.

The only thing we really need to cache IMO is security groups, and in almost every place where they are read, we provide a link to refresh the cache. So we can get rid of the entire section in the Application Config view, which is better, anyway, since those caches are not specific to the application (we just didn't have a better place to handle it).

There are a handful of other caches that seem like they don't need to be caches, and they are all in GCE: addresses, certificates, healthChecks. I don't know enough about those calls or spots in the code to feel comfortable removing them, but if @maggieneterval or @sbwsg or @louisjimenez have time to take a look (search for InfrastructureCaches.get('addresses') etc to see the usage), I think it'd be nice to remove them, and then do a bigger refactor of the whole InfrastructureCaches bit.

Also worth pulling this down and confirming everything still works on kubernetes (and other providers). I've tested on AWS and it all seems fine.

@archana-s
Copy link
Contributor

Didn't realize it would clean up so much! Thanks for doing this.

@maggieneterval
Copy link
Contributor

Wow, what an amazing cleanup! I will pull this down and run through some k8s workflows now, will give the thumbs up once I'm done. Thanks a bunch @anotherchrisberry!

@maggieneterval maggieneterval self-requested a review March 12, 2019 14:31
maggieneterval
maggieneterval approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing seems broken for k8s! Only thing I noticed is that we're now getting this eslint error, can we remove the API import from this file?

/usr/local/google/home/mneterval/dev/spinnaker/deck/app/scripts/modules/azure/instance/azureInstanceType.service.js 6:10 error 'API' is defined but never used no-unused-vars

@maggieneterval maggieneterval mentioned this pull request Mar 12, 2019
Closed
@maggieneterval
Copy link
Contributor

And regarding the GCE cleanup, I made a ticket so we don't forget to do this at some point: spinnaker/spinnaker#4102
😄

@anotherchrisberry
Copy link
Contributor Author

Awesome, thank you for taking a look @maggieneterval! I cleaned up that unused import and will get this merged.

@anotherchrisberry anotherchrisberry merged commit e2b4d8e into spinnaker:master Mar 12, 2019
@anotherchrisberry anotherchrisberry deleted the bye-caches branch March 12, 2019 15:44
@anotherchrisberry anotherchrisberry mentioned this pull request Mar 12, 2019
Merged
anotherchrisberry added a commit that referenced this pull request Mar 12, 2019
@anotherchrisberry
Bump package core to 0.0.343 and amazon to 0.0.179 and titus to 0.0.79 (
1deafa4 
#6672)

* chore(core): Bump version to 0.0.343

eacfe75 feat(core): Warning message about invalid job params (#6669)
a28f7af fix(core): Surface invalid params for a pipeline stage (#6668)
e2b4d8e refactor(*): remove unused local storage caches (#6665)
35e82ac feat(core): Add support for an Artifactory Trigger (#6664)
bc2bf43 feat(jenkins): Add artifact status tab to Jenkins execution details (#6666)
e0bda86 feat(artifacts): Re-use artifacts when re-running a pipeline (#6663)
29582dd feat(core): Filter v2 pipeline templates from create pipeline modal (#6660)
45678a1 fix(core/pipeline): make cancelmodal take markdown for body (#6662)
02af17f fix(artifacts): Correct render-if-feature for new artifacts on stage 'produces artifact' (#6661)
0eb634c fix(artifacts): Maven/ivy reference field, Base64 validation, SpelText performance (#6656)
93e89be fix(core): Remove ability to trigger manual exec for mptv2 pipelines (#6651)
d3209d4 feat(core): Add pipeline to IStageConfigProps (#6655)
1bc94a1 chore(angularjs): explicitly annotate more angularjs injections (#6653)
78d0aae fix(artifacts): save HTTP URL as artifact reference (#6650)
09d7fee fix({core,amazon}/serverGroup): filter out empty tags, change 'tags' field type (#6645)
8e9cb0b fix(core): titus run jobs override all other providers (#6647)
12e3bff fix(core): Remove configure button and setup redirect for mptv2 pipeline (#6644)
5da2965 refactor(artifacts): Combine expected artifacts and trigger artifact constraints (#6634)
eae6b45 feat(users): Always surface authenticated user for executions/tasks (#6638)

* chore(amazon): Bump version to 0.0.179

e2b4d8e refactor(*): remove unused local storage caches (#6665)
09d7fee fix({core,amazon}/serverGroup): filter out empty tags, change 'tags' field type (#6645)

* chore(titus): Bump version to 0.0.79

e2b4d8e refactor(*): remove unused local storage caches (#6665)
maggieneterval added a commit to maggieneterval/deck that referenced this pull request May 10, 2019
@maggieneterval
chore(kubernetes): Bump version to 0.0.22
a9f3a97 
1ada021 feat(kubernetes): expose rendered helm template in execution details (spinnaker#6943)
d122749 feat(runJob/kubernetes): render external link (spinnaker#6930)
9e03e52 refactor(runJob/kubernetes): refactor exec details (spinnaker#6924)
98ca0ff refactor(runJob/kubernetes): use joblogviewer (spinnaker#6917)
6c5eed6 feat(provider/kubernetes): run job manifest artifacts (spinnaker#6902)
cd8780c fix(kubernetes): fix discrepancy between orca deploy stage model and artifacts rewrite stage model
d44be0c fix(kubernetes): hide manifest artifact selector in text mode
bd94593 feat(kubernetes): remove rollout strategies feature flag
0ec6a7e feat(kubernetes): validate text manifests when rollout strategies enabled
37e24d7 fix(kubernetes): safer lookups for deploy stage validators (spinnaker#6847)
478e326 feat(kubernetes): add rollout strategies to deploy manifest stage (spinnaker#6841)
e618548 feat(preconfiguredJob): logs for k8s jobs (spinnaker#6840)
c30058a feat(k8s): Exclude inline base 64 artifact editing in k8s manifest (spinnaker#6839)
5640431 fix(k8s): Fix deploy manifest (spinnaker#6833)
ee89a64 feat(kuberntes): v2 runJob (spinnaker#6831)
2d7f388 feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (spinnaker#6816)
33ad914 chore(kubernetes): refactor BasicSettings component to be usable in stages (spinnaker#6820)
72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802)
d7f6fbd fix(kubernetes): show Deployment clusters in Find Artifacts from Resource stages (spinnaker#6794)
20d0d7a fix(kubernetes): safe lookups for apiVersion on patch manifest deploy status (spinnaker#6775)
bf13a3c fix(kubernetes): fix validation for Find Artifact from Resource stage (spinnaker#6777)
50b74f2 feat(gcb): add Google Cloud Build stage (spinnaker#6774)
5b03078 fix(kubernetes): fix copy manifest from infrastructure button (spinnaker#6719)
57c30b5 fix(kubernetes): Use apiGroup when looking up deploy status for CRDs (spinnaker#6691)
a5a54bd feat(kubernetes): add expression evaluation options to bake and deploy manifest stages (spinnaker#6696)
51eeba4 chore(core): upgrade the version to formik 1.4.1 (spinnaker#6705)
e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665)
5da2965 refactor(artifacts): Combine expected artifacts and trigger artifact constraints (spinnaker#6634)
0d37cb2 fix(kubernetes): only set manifestName in static mode manifest selector
79a0700 feat(kubernetes): add dynamic target selection to patch manifest stage
0abce66 fix(kubernetes): remove unnecessary delete manifest stage defaults
5bf6045 fix(kubernetes): allow text input for replicas in `Scale (Manifest)` stage (spinnaker#6630)
cbfcae4 feat(kubernetes): add label mode to manifest selector component to enable dynamic target selection in delete manifest stage (spinnaker#6628)
d828a53 chore(angularjs): Explicitly annotate directive controllers
3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (spinnaker#6604)
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600)
04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
4b91b36 refactor(core): move Ace Editor CSS to core module (spinnaker#6588)
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
629613f fix(kubernetes): properly detect if autoscaler is attached to server groups (spinnaker#6578)
d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase
@maggieneterval maggieneterval mentioned this pull request May 10, 2019
Merged
maggieneterval added a commit that referenced this pull request May 10, 2019
@maggieneterval
chore(kubernetes): Bump version to 0.0.22 (#6969)
04cbe5f 
1ada021 feat(kubernetes): expose rendered helm template in execution details (#6943)
d122749 feat(runJob/kubernetes): render external link (#6930)
9e03e52 refactor(runJob/kubernetes): refactor exec details (#6924)
98ca0ff refactor(runJob/kubernetes): use joblogviewer (#6917)
6c5eed6 feat(provider/kubernetes): run job manifest artifacts (#6902)
cd8780c fix(kubernetes): fix discrepancy between orca deploy stage model and artifacts rewrite stage model
d44be0c fix(kubernetes): hide manifest artifact selector in text mode
bd94593 feat(kubernetes): remove rollout strategies feature flag
0ec6a7e feat(kubernetes): validate text manifests when rollout strategies enabled
37e24d7 fix(kubernetes): safer lookups for deploy stage validators (#6847)
478e326 feat(kubernetes): add rollout strategies to deploy manifest stage (#6841)
e618548 feat(preconfiguredJob): logs for k8s jobs (#6840)
c30058a feat(k8s): Exclude inline base 64 artifact editing in k8s manifest (#6839)
5640431 fix(k8s): Fix deploy manifest (#6833)
ee89a64 feat(kuberntes): v2 runJob (#6831)
2d7f388 feat(kubernetes): feature-flagged support for kubernetes traffic management strategies (#6816)
33ad914 chore(kubernetes): refactor BasicSettings component to be usable in stages (#6820)
72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802)
d7f6fbd fix(kubernetes): show Deployment clusters in Find Artifacts from Resource stages (#6794)
20d0d7a fix(kubernetes): safe lookups for apiVersion on patch manifest deploy status (#6775)
bf13a3c fix(kubernetes): fix validation for Find Artifact from Resource stage (#6777)
50b74f2 feat(gcb): add Google Cloud Build stage (#6774)
5b03078 fix(kubernetes): fix copy manifest from infrastructure button (#6719)
57c30b5 fix(kubernetes): Use apiGroup when looking up deploy status for CRDs (#6691)
a5a54bd feat(kubernetes): add expression evaluation options to bake and deploy manifest stages (#6696)
51eeba4 chore(core): upgrade the version to formik 1.4.1 (#6705)
e2b4d8e refactor(*): remove unused local storage caches (#6665)
5da2965 refactor(artifacts): Combine expected artifacts and trigger artifact constraints (#6634)
0d37cb2 fix(kubernetes): only set manifestName in static mode manifest selector
79a0700 feat(kubernetes): add dynamic target selection to patch manifest stage
0abce66 fix(kubernetes): remove unnecessary delete manifest stage defaults
5bf6045 fix(kubernetes): allow text input for replicas in `Scale (Manifest)` stage (#6630)
cbfcae4 feat(kubernetes): add label mode to manifest selector component to enable dynamic target selection in delete manifest stage (#6628)
d828a53 chore(angularjs): Explicitly annotate directive controllers
3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (#6604)
7d5fc34 chore(prettier): Just Use Prettier™ (#6600)
04bb4a0 fix(html): Fix various invalid HTML (#6599)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
4b91b36 refactor(core): move Ace Editor CSS to core module (#6588)
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
629613f fix(kubernetes): properly detect if autoscaler is attached to server groups (#6578)
d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Jun 5, 2019
@christopherthielen
chore(oracle): Bump version to 0.0.2
8496fbe 
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (spinnaker#6861)
72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802)
e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665)
0cdcb1e fix(bake/oracle): Added extendedAttributes (spinnaker#6627)
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600)
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase
a8c1749 chore(package): Just Update Prettier™
5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()'
0451046 chore(package): Add .npmignore to all packages
6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment)
35be1f0 refactor(*): Don't use js or ts file extension in require()
ca71ab6 fix(oracle/pipeline): Rename ng module to spinnaker.oracle.* (spinnaker#6219)
6b8188b chore(*): Add core alias to module tsconfigs
af292f6 fix(imports): Avoid "import { thing } from 'core'"
d1acd1b fix(provider/oracle): fix update/edit LoadBalancer (spinnaker#6043)
72e1e8d fix(provider/oracle): add ssh key (spinnaker#5901)
2f3ca8d feat(provider/oracle): create/delete LoadBalancer (spinnaker#5868)
55987ec fix(bake): Execution details Rebake was always false when force rebaking
a74a7f3 fix(bakery/oracle): use read-only text field for bake region (spinnaker#5843)
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Jun 5, 2019
@christopherthielen
chore(google): Bump version to 0.0.6
7ed79c6 
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (spinnaker#6929)
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (spinnaker#6861)
297cd99 feat(provider/google): Support Shielded VM policies (spinnaker#6849)
728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (spinnaker#6751)" (spinnaker#6808)
bdcbc97 fix(google): GCE create server group and load balancer fixes (spinnaker#6806)
72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (spinnaker#6802)
0daec5b fix(google): fix autohealing health checks in deploy stages (spinnaker#6804)
ad2e222 fix(google): select all zones by default when deploying a regional gce server group (spinnaker#6751)
432e6e3 fix(google): add better help text around accelerators (spinnaker#6750)
eb7f661 feat(provider/gce): Moniker support for GCE server groups (spinnaker#6317)
e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665)
f0f4c0d fix(google): Only show authorized accounts during Server group creation (spinnaker#6625)
d828a53 chore(angularjs): Explicitly annotate directive controllers
3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (spinnaker#6604)
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600)
04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599)
64fb489 fix(html): Fix various invalid HTML (spinnaker#6597)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (spinnaker#6569)
ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
@christopherthielen christopherthielen mentioned this pull request Jun 5, 2019
Merged
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Jun 5, 2019
@christopherthielen
chore(appengine): Bump version to 0.0.6
a88c888 
e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665)
49affe7 fix(appengine): allow sequence to be suppressed in servergroup names (spinnaker#6667)
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define
ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
a35088a chore(webpack): Switch to TerserPlugin.  Split bundles into ~5mb chunks
5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()'
0451046 chore(package): Add .npmignore to all packages
6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment)
93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (spinnaker#6347)
86baac9 refactor(*): use mask-image CSS for cloud provider logos (spinnaker#6280)
8cef885 fix(appengine): move artifact account dropdown below radio buttons (spinnaker#6255)
6b8188b chore(*): Add core alias to module tsconfigs
c190c41 fix(appengine): the selectedProvider is received as null when Create Server Group btn clicked (spinnaker#5908)
351d4fb feat(appengine): unflag container image url deployments (spinnaker#5894)
0a6d3f9 feat(provider/appengine): enable artifacts as config files (spinnaker#5888)
bdca8aa feat(appengine): move config template into html file (spinnaker#5870)
christopherthielen added a commit to christopherthielen/deck that referenced this pull request Jun 5, 2019
@christopherthielen
chore(ecs): Bump version to 0.0.249
65ad73d 
8398d77 refactor(*): make accountExtractor return an array of strings (spinnaker#7068)
1c61cb2 feat(ecs): service discovery configuration (spinnaker#6899)
654fd3a feat(ecs): Configuration for platform version & placement constraints (spinnaker#6906)
c550d82 feat(ecs): Configure tags (spinnaker#6905)
269d005 fix(ecs): populate load balancers when configuring cmd (spinnaker#6778)
6a76b5f fix(ecs): Fix name of health check grace period attribute (spinnaker#6746)
1c9e075 feat(ecs): docker image selection (spinnaker#6687)
d63dc6d fix(ecs): Remove unused cacheInitializer injection (spinnaker#6681)
e2b4d8e refactor(*): remove unused local storage caches (spinnaker#6665)
2e3fad2 fix(ecs/instance): restore accidentally deleted section in instance details
7d5fc34 chore(prettier): Just Use Prettier™ (spinnaker#6600)
04bb4a0 fix(html): Fix various invalid HTML (spinnaker#6599)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
a35088a chore(webpack): Switch to TerserPlugin.  Split bundles into ~5mb chunks
5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()'
0451046 chore(package): Add .npmignore to all packages
6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment)
35be1f0 refactor(*): Don't use js or ts file extension in require()
56ce321 feat(ecs): Add option to copy scaling policies from previous server group (spinnaker#6251)
e802c45 fix(*): allow modal to stay open on auto-close (spinnaker#6329)
86baac9 refactor(*): use mask-image CSS for cloud provider logos (spinnaker#6280)
5d0d72a fix(provider/ecs): Add memory limit to server group details (spinnaker#6135)
6b8188b chore(*): Add core alias to module tsconfigs
190064f feat(ecs): support private registry credentials (spinnaker#5799)
christopherthielen added a commit that referenced this pull request Jun 5, 2019
@christopherthielen
chore(oracle): Bump version to 0.0.2
b51ca4b 
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (#6861)
72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802)
e2b4d8e refactor(*): remove unused local storage caches (#6665)
0cdcb1e fix(bake/oracle): Added extendedAttributes (#6627)
7d5fc34 chore(prettier): Just Use Prettier™ (#6600)
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
d72bc17 fix(eslint): Fix eslint warnings for @typescript-eslint/camelcase
a8c1749 chore(package): Just Update Prettier™
5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()'
0451046 chore(package): Add .npmignore to all packages
6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment)
35be1f0 refactor(*): Don't use js or ts file extension in require()
ca71ab6 fix(oracle/pipeline): Rename ng module to spinnaker.oracle.* (#6219)
6b8188b chore(*): Add core alias to module tsconfigs
af292f6 fix(imports): Avoid "import { thing } from 'core'"
d1acd1b fix(provider/oracle): fix update/edit LoadBalancer (#6043)
72e1e8d fix(provider/oracle): add ssh key (#5901)
2f3ca8d feat(provider/oracle): create/delete LoadBalancer (#5868)
55987ec fix(bake): Execution details Rebake was always false when force rebaking
a74a7f3 fix(bakery/oracle): use read-only text field for bake region (#5843)
christopherthielen added a commit that referenced this pull request Jun 5, 2019
@christopherthielen
chore(google): Bump version to 0.0.6
fc7645a 
243f530 feat(provdier/google): Display serviceAccount properties for firewall rules (#6929)
0a5fd58 refactor(*): remove cache-clearing calls that do not do anything (#6861)
297cd99 feat(provider/google): Support Shielded VM policies (#6849)
728ddbe fix(google): revert "select all zones by default when deploying a regional gce server group (#6751)" (#6808)
bdcbc97 fix(google): GCE create server group and load balancer fixes (#6806)
72e164d refactor(core): de-angularize ApplicationModelBuilder, fix project executions (#6802)
0daec5b fix(google): fix autohealing health checks in deploy stages (#6804)
ad2e222 fix(google): select all zones by default when deploying a regional gce server group (#6751)
432e6e3 fix(google): add better help text around accelerators (#6750)
eb7f661 feat(provider/gce): Moniker support for GCE server groups (#6317)
e2b4d8e refactor(*): remove unused local storage caches (#6665)
f0f4c0d fix(google): Only show authorized accounts during Server group creation (#6625)
d828a53 chore(angularjs): Explicitly annotate directive controllers
3e75815 refactor(core): migrate momentjs functionality to luxon + date-fns (#6604)
7d5fc34 chore(prettier): Just Use Prettier™ (#6600)
04bb4a0 fix(html): Fix various invalid HTML (#6599)
64fb489 fix(html): Fix various invalid HTML (#6597)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
78d0b68 fix(securityGroups): User `securityGroupName` for upsertSecurityGroupTask (#6569)
ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
8cba7ac fix(eslint): Fix eslint warnings for no-case-declarations
christopherthielen added a commit that referenced this pull request Jun 5, 2019
@christopherthielen
chore(appengine): Bump version to 0.0.6
b37fc81 
e2b4d8e refactor(*): remove unused local storage caches (#6665)
49affe7 fix(appengine): allow sequence to be suppressed in servergroup names (#6667)
7d5fc34 chore(prettier): Just Use Prettier™ (#6600)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
e1b6663 fix(eslint): Fix eslint warnings for @typescript-eslint/no-use-before-define
ddbe208 fix(eslint): Fix eslint warnings for no-useless-escape
a35088a chore(webpack): Switch to TerserPlugin.  Split bundles into ~5mb chunks
5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()'
0451046 chore(package): Add .npmignore to all packages
6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment)
93f1209 fix(appengine/google/kubernetes): change logo background colors to official brand colors (#6347)
86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280)
8cef885 fix(appengine): move artifact account dropdown below radio buttons (#6255)
6b8188b chore(*): Add core alias to module tsconfigs
c190c41 fix(appengine): the selectedProvider is received as null when Create Server Group btn clicked (#5908)
351d4fb feat(appengine): unflag container image url deployments (#5894)
0a6d3f9 feat(provider/appengine): enable artifacts as config files (#5888)
bdca8aa feat(appengine): move config template into html file (#5870)
christopherthielen added a commit that referenced this pull request Jun 5, 2019
@christopherthielen
chore(ecs): Bump version to 0.0.249
3eafc27 
8398d77 refactor(*): make accountExtractor return an array of strings (#7068)
1c61cb2 feat(ecs): service discovery configuration (#6899)
654fd3a feat(ecs): Configuration for platform version & placement constraints (#6906)
c550d82 feat(ecs): Configure tags (#6905)
269d005 fix(ecs): populate load balancers when configuring cmd (#6778)
6a76b5f fix(ecs): Fix name of health check grace period attribute (#6746)
1c9e075 feat(ecs): docker image selection (#6687)
d63dc6d fix(ecs): Remove unused cacheInitializer injection (#6681)
e2b4d8e refactor(*): remove unused local storage caches (#6665)
2e3fad2 fix(ecs/instance): restore accidentally deleted section in instance details
7d5fc34 chore(prettier): Just Use Prettier™ (#6600)
04bb4a0 fix(html): Fix various invalid HTML (#6599)
5cf6c79 chore(prettier): Just Use Prettier™
3ffa4fb chore(angularjs): Do not use .component('foo', new Foo())
cc52bee chore(angularjs): Remove all 'ngInject'; in favor of explicit DI annotation
b6bab1e chore(prettier): Just Use Prettier™
f3fd790 chore(angularjs): Explicitly annotate all AngularJS injection points
a35088a chore(webpack): Switch to TerserPlugin.  Split bundles into ~5mb chunks
5c49dd2 chore(typescript): Switch module from 'commonjs' to 'esnext' to emit raw dynamic 'import()'
0451046 chore(package): Add .npmignore to all packages
6f608a0 fix(*): Remove all self closing tags in AngularJS templates Reference: angular/angular.js#1953 (comment)
35be1f0 refactor(*): Don't use js or ts file extension in require()
56ce321 feat(ecs): Add option to copy scaling policies from previous server group (#6251)
e802c45 fix(*): allow modal to stay open on auto-close (#6329)
86baac9 refactor(*): use mask-image CSS for cloud provider logos (#6280)
5d0d72a fix(provider/ecs): Add memory limit to server group details (#6135)
6b8188b chore(*): Add core alias to module tsconfigs
190064f feat(ecs): support private registry credentials (#5799)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maggieneterval maggieneterval maggieneterval approved these changes

Assignees
No one assigned
Labels
target-release/1.13
Projects
None yet
Milestone
No milestone
4 participants
@anotherchrisberry @archana-s @maggieneterval @spinnakerbot