fix(provider/azure): Fix UI for Azure Load Balancer in server group c… #7055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
linked with spinnaker/clouddriver#3713 |
|
@maggieneterval, please possibly help apply this hotfix PR to v1.14.0. To supplement the background, though there are multiple bug fixes included, the cause could be regarded as unique that we brought in the 2nd Spinnaker Load Balancer type for Azure: Azure Load Balancer (ALB). Between the 2 types of Azure Load Balancers (Load Balancer and Application Gateway), there is compatibility issue which resulted in the above symptoms. |
maggieneterval
approved these changes
May 23, 2019
| @@ -38,7 +38,7 @@ <h3 class="horizontal middle space-between flex-1" select-on-dbl-click> | |||
| class="disabled" | |||
| tooltip="You must detach all server groups before you can delete this load balancer." | |||
| > | |||
| <a href ng-click="ctrl.deleteLoadBalancer()">Delete Load Balancer</a> | |||
| <a href>Delete Load Balancer</a> | |||
There was a problem hiding this comment.
Did you mean to remove the click handler?
|
@spinnakerbot cherry-pick 1.14 |
spinnakerbot
pushed a commit
that referenced
this pull request
May 23, 2019
|
Cherry pick successful: #7057 |
maggieneterval
pushed a commit
that referenced
this pull request
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix the issues:
We hope this PR could be applied to v1.14.0 as a hotfix, thanks!