fix(k8s/runJob): Allowing only v1 accounts for v1 runJob #7258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a v2 account would have com.netflix.spinnaker.clouddriver.kubernetes.v2.op.job.KubernetesRunJobOperation be called and throw an NPE at line 70, because there's no manifest.
|
@spinnakerbot cherry-pick 1.15 |
spinnakerbot
pushed a commit
that referenced
this pull request
Jul 24, 2019
Using a v2 account would have com.netflix.spinnaker.clouddriver.kubernetes.v2.op.job.KubernetesRunJobOperation be called and throw an NPE at line 70, because there's no manifest.
|
Cherry pick successful: #7259 |
maggieneterval
pushed a commit
that referenced
this pull request
Jul 24, 2019
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Jul 26, 2019
4dba1b1 fix(k8s/runJob): External logs URL to support manifest with implicit default namespace (spinnaker#7252) 4edc5f7 fix(k8s/runJob): Allowing only v1 accounts for v1 runJob (spinnaker#7258)
christopherthielen
added a commit
that referenced
this pull request
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a v2 account would have
com.netflix.spinnaker.clouddriver.kubernetes.v2.op.job.KubernetesRunJobOperationbe called and throw an NPE at line 70, because there's no manifest.