fix(cf): Deploy stage config template import missing routes #7291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the imported server group had no routes, the routes property would be undefined where it should have been an empty array. spinnaker/spinnaker#4711
Jammy-Louie
approved these changes
Aug 6, 2019
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Aug 8, 2019
0488d51 fix(cf): Deploy stage config template import missing routes (spinnaker#7291) abac63c feat(*/pipeline): Remove the concept of default stage timeouts, rename option (spinnaker#7286) dd5bb02 feat(cf): Logs for Run Job stage (spinnaker#7263) 9c7885f feat(core/presentation): Add a <Formik/> wrapper which applies fixes and opinions that we want in Spinnaker (spinnaker#7272)
christopherthielen
added a commit
that referenced
this pull request
Aug 8, 2019
0488d51 fix(cf): Deploy stage config template import missing routes (#7291) abac63c feat(*/pipeline): Remove the concept of default stage timeouts, rename option (#7286) dd5bb02 feat(cf): Logs for Run Job stage (#7263) 9c7885f feat(core/presentation): Add a <Formik/> wrapper which applies fixes and opinions that we want in Spinnaker (#7272)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the imported server group had no routes, the routes property would be undefined where it should have been an empty array. spinnaker/spinnaker#4711