fix(tasks): Not bothering with null user when we have an authed one #7305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -147,8 +147,9 @@ <h4> | |||
| </span> | |||
| </td> | |||
| <td> | |||
| {{ task.execution.authentication.user === task.getValueFor('user') ? task.execution.authentication.user | |||
| : (task.getValueFor('user') + ' (' + (task.execution.authentication.user || 'unknown user') + ')') }} | |||
| {{ task.getValueFor('user') ? ( (task.execution.authentication.user === task.getValueFor('user')) ? | |||
There was a problem hiding this comment.
I know this is angular code and we're not investing in it, but I find this particularly difficult to read
There was a problem hiding this comment.
Agree. It was prettier before prettier
christopherthielen
approved these changes
Aug 8, 2019
|
Thanks @alanmquach! |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Aug 13, 2019
40c3197 refactor(core/presentation): use render props everywhere (spinnaker#7316) cef1c09 fix(core/presentation): prevent the hover jitters on pipeline graph labels (spinnaker#7311) 74ea2e7 fix(ui): require application, pipeline, and a status when adding a pipeline trigger (spinnaker#7308) f3de167 fix(ui): require type on the stage (spinnaker#7304) 834f4ea feat(helm): allow manual execution overrides for helm charts (spinnaker#7312) ea29d8d fix(tasks): Not bothering with null user when we have an authed one (spinnaker#7305)
christopherthielen
added a commit
that referenced
this pull request
Aug 13, 2019
40c3197 refactor(core/presentation): use render props everywhere (#7316) cef1c09 fix(core/presentation): prevent the hover jitters on pipeline graph labels (#7311) 74ea2e7 fix(ui): require application, pipeline, and a status when adding a pipeline trigger (#7308) f3de167 fix(ui): require type on the stage (#7304) 834f4ea feat(helm): allow manual execution overrides for helm charts (#7312) ea29d8d fix(tasks): Not bothering with null user when we have an authed one (#7305)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null ( authenticated user )seems silly when we can just displayauthenticated userEspecially since the authenticated user is the stronger identity.