fix(core/pipeline): Refresh jenkins jobs component when manual execution trigger is changed #7323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion trigger is changed In Manual Execution dialog, we have a dropdown that selects the correct trigger When the user changes the selected trigger, we now force the trigger's custom component to remount. This is a kludge and some day we should remove it. Instead, all the trigger type components should properly respond to changes in the props passed to it.
christopherthielen
force-pushed
the
refresh-jenkins-jobs-when-changing-trigger
branch
from
0b3f214
to
e8cc1f6
Compare
christopherthielen
deleted the
refresh-jenkins-jobs-when-changing-trigger
branch
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Aug 14, 2019
598b5b3 refactor(hooks): Pulling out useData (spinnaker#7325) 0fbafe6 fix(core/pipeline): Refresh jenkins jobs component when manual execution trigger is changed (spinnaker#7323) 1251159 fix(core/pipeline): make dropdown option labels always be strings (spinnaker#7322) 1e779ef perf(core): avoid nested looping in execution transformation (spinnaker#7217) bec54df refactor(core): Reactify the pipeline trigger configuration (spinnaker#7318)
christopherthielen
added a commit
that referenced
this pull request
Aug 14, 2019
598b5b3 refactor(hooks): Pulling out useData (#7325) 0fbafe6 fix(core/pipeline): Refresh jenkins jobs component when manual execution trigger is changed (#7323) 1251159 fix(core/pipeline): make dropdown option labels always be strings (#7322) 1e779ef perf(core): avoid nested looping in execution transformation (#7217) bec54df refactor(core): Reactify the pipeline trigger configuration (#7318)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Manual Execution dialog, we have a dropdown where a user selects the desired trigger.
When they change the selected trigger, we now force the trigger's custom component to remount.
This is a kludge and some day we should remove it.
Instead, all the trigger type components should properly respond to changes in the props passed to it.