refactor(core): Reactify the pipeline trigger configuration #7318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggieneterval
approved these changes
Aug 13, 2019
app/scripts/modules/core/src/pipeline/config/pipelineConfigurer.js
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/ExpectedArtifactsPageContent.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/ExpectedArtifactsPageContent.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/ExpectedArtifactsPageContent.tsx
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/ParametersPageContent.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/artifacts/ExpectedArtifact.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/Triggers.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/TriggersPageContent.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/TriggersPageContent.tsx
Outdated
Show resolved
Hide resolved
app/scripts/modules/core/src/pipeline/config/triggers/TriggersPageContent.tsx
Outdated
Show resolved
Hide resolved
|
Hey @Jammy-Louie I'm seeing some strange behavior on my dev Spinnaker when I run against this commit (but not the prior commit) -- with artifacts rewrite disabled, all my expected artifacts in a pipeline config are being changed to base64 when I open the pipeline config: Before: After: Not sure if something wonky is going on with my pipelines or if you are also able to reproduce by 1) turning artifacts rewrite off 2) opening any pipeline config with at least one non-base64 artifact? |
|
let me investigate @maggieneterval |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Aug 14, 2019
598b5b3 refactor(hooks): Pulling out useData (spinnaker#7325) 0fbafe6 fix(core/pipeline): Refresh jenkins jobs component when manual execution trigger is changed (spinnaker#7323) 1251159 fix(core/pipeline): make dropdown option labels always be strings (spinnaker#7322) 1e779ef perf(core): avoid nested looping in execution transformation (spinnaker#7217) bec54df refactor(core): Reactify the pipeline trigger configuration (spinnaker#7318)
christopherthielen
added a commit
that referenced
this pull request
Aug 14, 2019
598b5b3 refactor(hooks): Pulling out useData (#7325) 0fbafe6 fix(core/pipeline): Refresh jenkins jobs component when manual execution trigger is changed (#7323) 1251159 fix(core/pipeline): make dropdown option labels always be strings (#7322) 1e779ef perf(core): avoid nested looping in execution transformation (#7217) bec54df refactor(core): Reactify the pipeline trigger configuration (#7318)
jervi
added a commit
to jervi/deck
that referenced
this pull request
Sep 26, 2019
Reverting these lines to pre spinnaker#7318 fixes the issue
Jammy-Louie
pushed a commit
to jervi/deck
that referenced
this pull request
Sep 26, 2019
Reverting these lines to pre spinnaker#7318 fixes the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored pipeline config from Angular to React