fix(titus/pipeline): use proper git ssh URL for docker bakes #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
approved these changes
Oct 2, 2019
|
i don't make the rules, i just follow them 🤷♂ |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 7, 2019
c6c69a3 fix(titus/pipeline): use proper git ssh URL for docker bakes (spinnaker#7480)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
c6c69a3 fix(titus/pipeline): use proper git ssh URL for docker bakes (spinnaker#7480)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most Titus users at Netflix use the option to pull git repository information from the pipeline trigger, which uses expressions to build up a git URL which is passed to our internal bakery.
Turns out that when not using that option and specifying a branch/hash/etc. yourself in the stage, we weren't putting the appropriate query string
?before the hash component of the URL.