Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google): permit guest accelerator config for regional server groups with zones explicitly selected #7528

Merged
merged 3 commits into from
Oct 15, 2019

Conversation

maggieneterval
Copy link
Contributor

@maggieneterval maggieneterval commented Oct 15, 2019

Front-end component for: spinnaker/spinnaker#4796
Should not be merged until Clouddriver component is merged: spinnaker/clouddriver#4092

  • refactor(google): convert accelerator config component to react
  • feat(google): permit guest accelerator config for regional server groups with zones explicitly selected

Example:

Regional MIG created with Spinnaker with two defined regions...

XhKbYhQzAWo

...with configured accelerator...

UDy4F864Zzp

...per GPU zonal restrictions!

rqumnrRm3PJ

@maggieneterval maggieneterval added the Do Not Merge Don't merge yet label Oct 15, 2019
@maggieneterval maggieneterval removed the Do Not Merge Don't merge yet label Oct 15, 2019
Copy link
Member

@plumpy plumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍡 🍡 🎉

@maggieneterval maggieneterval merged commit b41a8c6 into spinnaker:master Oct 15, 2019
@maggieneterval maggieneterval deleted the multi-zone-accel branch October 15, 2019 20:23
yunzhangit pushed a commit to yunzhangit/deck that referenced this pull request Mar 28, 2021
…ups with zones explicitly selected (spinnaker#7528)

* refactor(google): convert accelerator config component to react

* feat(google): permit guest accelerator config for regional server groups with zones explicitly selected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants