fix(core): Ensure default port used for target group healthcheck link #7576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikmunson
approved these changes
Oct 30, 2019
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Oct 30, 2019
34a3b00 feat(managed): Update resource indicators to use new data source 4ed015a feat(dataSources): widen + parameterize types, add default values 57c7d6d fix(core): Ensure default port used for target group healthcheck link (spinnaker#7576)
christopherthielen
added a commit
that referenced
this pull request
Oct 30, 2019
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Nov 8, 2019
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Nov 8, 2019
34a3b00 feat(managed): Update resource indicators to use new data source 4ed015a feat(dataSources): widen + parameterize types, add default values 57c7d6d fix(core): Ensure default port used for target group healthcheck link (spinnaker#7576)
sergiopena
pushed a commit
to sergiopena/deck
that referenced
this pull request
Jan 10, 2020
sergiopena
pushed a commit
to sergiopena/deck
that referenced
this pull request
Jan 10, 2020
34a3b00 feat(managed): Update resource indicators to use new data source 4ed015a feat(dataSources): widen + parameterize types, add default values 57c7d6d fix(core): Ensure default port used for target group healthcheck link (spinnaker#7576)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
34a3b00 feat(managed): Update resource indicators to use new data source 4ed015a feat(dataSources): widen + parameterize types, add default values 57c7d6d fix(core): Ensure default port used for target group healthcheck link (spinnaker#7576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain providers have a default configuration for their health check port, so we need fall back on the port assigned to the target group in this case.
e.g: Amazon defaults to
heatlhCheckPort = traffic-portinstead of a numerical value. The url was constructed with:traffic-portinstead of the actual port.