fix(rosco): Re-evaluate roscoSelector on stage updates #7577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanmquach
added a commit
to alanmquach/deck
that referenced
this pull request
Oct 29, 2019
d620e05 fix(rosco): Re-evaluate roscoSelector on stage updates (spinnaker#7577) dae00c8 feat(rosco): Allow optional roscoDetailUrl for roscoMode bakes (spinnaker#7575)
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Nov 8, 2019
Jammy-Louie
pushed a commit
to pivotal/deck
that referenced
this pull request
Nov 8, 2019
d620e05 fix(rosco): Re-evaluate roscoSelector on stage updates (spinnaker#7577) dae00c8 feat(rosco): Allow optional roscoDetailUrl for roscoMode bakes (spinnaker#7575)
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
d620e05 fix(rosco): Re-evaluate roscoSelector on stage updates (spinnaker#7577) dae00c8 feat(rosco): Allow optional roscoDetailUrl for roscoMode bakes (spinnaker#7575)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fix,
roscoModeonly got evaluated once, but ifroscoSelectoris used, we should really evaluate every time the stage is updated so that changes that cause the result to flip betweentrueandfalseappropriately fliproscoModeand the bake stage config is updated appropriately (rosco fields toggled).