refactor(artifacts): consolidate artifacts feature flags checks #8096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggieneterval
commented
Mar 25, 2020
maggieneterval
force-pushed
the
artifacts-feature-flags-fun
branch
from
f4a86ad
to
0f4bbae
Compare
maggieneterval
force-pushed
the
artifacts-feature-flags-fun
branch
from
0f4bbae
to
16048c8
Compare
maggieneterval
force-pushed
the
artifacts-feature-flags-fun
branch
from
16048c8
to
0f80972
Compare
ezimanyi
approved these changes
Mar 26, 2020
yunzhangit
pushed a commit
to yunzhangit/deck
that referenced
this pull request
Mar 28, 2021
…naker#8096) * refactor(artifacts): consolidate artifacts feature flags checks * fix(artifacts): enable artifact-specific stages when only `artifactsRewrite` feature flag is enabled * fix(artifacts): make artifactsMode read-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: spinnaker/governance#111
The
artifactsandartifactsRewriteflags were intended to be mutually exclusive, but it is possible that this was not fully thought through, as there are several workflows (Find Artifact from Resource stage, Find Artifact from Execution stage) that currently require both flags to be enabled in order to use with the new UI. This PR addresses that bug and consolidates the artifacts feature flag checks to a single service.refactor(artifacts): consolidate artifacts feature flags checks
Adds
ArtifactsModeService, which is responsible for the mapping between the four possible feature flag configuration states and the three possible UI experiences. Replaces each instance of logic conditional on one or both artifacts feature flags with logic conditional on the UI experience to which they map.fix(artifacts): enable artifact-specific stages when only
artifactsRewritefeature flag is enabledRegister the Find Artifact from Resource stage and Find Artifact from Execution stage if at least one of the two existing artifacts feature flags is enabled.
Pending a successful audit of the
STANDARDUI experience, we will:DISABLEDexperience (1.20).artifactsandartifactsRewritefeature flags (1.20).STANDARDexperience unless a new, temporarylegacyArtifactsflag is enabled (1.20).LEGACYexperience andlegacyArtifactsflag. With only theSTANDARDexperience remaining, we can remove theArtifactsModeServiceand all conditional calling code (1.21).