feat(core/managed): add proper support for skipped, approved artifact states #8142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently came to the realization that the
approved
andpending
states an artifact can have in a particular environment were a bit conceptually overloaded, because they both contained versions that had been skipped over due to later versions becoming available. This meant it was very challenging to explain whatapproved
andpending
meant in the UI because a version could either be in a state of approved-ness / pending-ness, or it could've been skipped and have no chance of ever being deployed.We've now split out a totally new state —
skipped
— to help clarify the semantics of the other two states, freeing upapproved
to mean "this version is about to start deploying" andpending
to mean "this version is actively under consideration for deployment, but hasn't been chosen yet". This change adds full-fledged support to all three of these statuses, as the inherent confusion had prevented us from adding useful UI treatments until this point. Looks like this:Pending:
Approved:
Skipped (version info available):
Skipped (no version info available):
Icons are coming soon (the
approved
one is also temporary), but wanted to get this out in advance of having iconography.(cc @gcomstock)