perf(kubernetes): Load manifest and instance details in parallel #8499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrieveInstance has a really long if block that would be clearer if we just returned null immediately if the data is missing (rather than have the usual path in a long block). Make that change separately to make the next diff smaller.
When opening an instance tab, we currently wait for the reqeust to /instances to finish before starting the request to /manifests even though we have the required information for both. This PR updates the Kubernetes instance provider to send both requests immediately, reducing the amount of time the user needs to wait for the instance tab to load.
maggieneterval
approved these changes
Aug 17, 2020
moki-daniel
pushed a commit
to moki-daniel/deck
that referenced
this pull request
Aug 28, 2020
…nnaker#8499) * refactor(kubernetes): Flip an if condition retrieveInstance has a really long if block that would be clearer if we just returned null immediately if the data is missing (rather than have the usual path in a long block). Make that change separately to make the next diff smaller. * perf(kubernetes): Load manifest and instance details in parallel When opening an instance tab, we currently wait for the reqeust to /instances to finish before starting the request to /manifests even though we have the required information for both. This PR updates the Kubernetes instance provider to send both requests immediately, reducing the amount of time the user needs to wait for the instance tab to load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(kubernetes): Flip an if condition
retrieveInstance has a really long if block that would be clearer if we just returned null immediately if the data is missing (rather than have the usual path in a long block). Make that change separately to make the next diff smaller.
perf(kubernetes): Load manifest and instance details in parallel
When opening an instance tab, we currently wait for the reqeust to
/instances to finish before starting the request to /manifests even though we have the required information for both.
This PR updates the Kubernetes instance provider to send both requests immediately, reducing the amount of time the user needs to wait for the instance tab to load.