Revert "fix(appname): encodeURIComponent for app name (#8586)" #8627
Conversation
This reverts commit f1bb04e.
caseyhebebrand
requested review from
christopherthielen and
german-muzquiz
and removed request for
christopherthielen
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
|
@german-muzquiz Please take a look. We need to rollout some changes on top of this PR, so we thought the easiest thing would be to revert until the issue could be resolved .The issue was that all of the slashes were replaced with space for any endpoint calls. |
|
@caseyhebebrand I'm trying to uderstand the issue, are you saying that after merging this PR, any and all API calls replace slashes by spaces? I didn't see that in my tests, can you elaborate a bit more for exactly which API calls did you see this? |
|
@german-muzquiz This lives in proprietary netflix code (think: plugins) that uses |
…e@0.0.517 docker@0.0.61 google@0.0.22 oracle@0.0.10 tencentcloud@0.0.7 (#8630) * chore(amazon): publish amazon@0.0.270 885cd16 Revert "fix(appname): encodeURIComponent for app name (#8586)" (#8627) * chore(azure): publish azure@0.0.256 885cd16 Revert "fix(appname): encodeURIComponent for app name (#8586)" (#8627) * chore(cloudfoundry): publish cloudfoundry@0.0.102 885cd16 Revert "fix(appname): encodeURIComponent for app name (#8586)" (#8627) * chore(core): publish core@0.0.517 885cd16 Revert "fix(appname): encodeURIComponent for app name (#8586)" (#8627) * chore(docker): publish docker@0.0.61 885cd16 Revert "fix(appname): encodeURIComponent for app name (#8586)" (#8627) * chore(google): publish google@0.0.22 885cd16 Revert "fix(appname): encodeURIComponent for app name (#8586)" (#8627) * chore(oracle): publish oracle@0.0.10 885cd16 Revert "fix(appname): encodeURIComponent for app name (#8586)" (#8627) * chore(tencentcloud): publish tencentcloud@0.0.7 885cd16 Revert "fix(appname): encodeURIComponent for app name (#8586)" (#8627)
Reverting the PR.