feat(eslint-plugin): Add a new rule api-no-slashes that forbids using string literals with slashes to API.one() #8629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
requested review from
vigneshm,
caseyhebebrand and
german-muzquiz
christopherthielen
force-pushed
the
eslint-rule-api-no-slashes
branch
from
7ffd905
to
b03eafd
Compare
caseyhebebrand
approved these changes
Oct 7, 2020
christopherthielen
force-pushed
the
eslint-rule-api-no-slashes
branch
2 times, most recently
from
c5d31cb
to
3cad0d3
Compare
… passing string literals to API.one() with slashes
christopherthielen
force-pushed
the
eslint-rule-api-no-slashes
branch
from
3cad0d3
to
97c0e9d
Compare
christopherthielen
changed the title
christopherthielen
changed the title
german-muzquiz
approved these changes
Oct 7, 2020
|
@christopherthielen at which point can we enable encoding in API again? I can create the PR in the meantime to have it ready, ideally it would be merged before release branches for |
christopherthielen
added a commit
to christopherthielen/deck
that referenced
this pull request
Nov 10, 2020
fix(pluginsdk-peerdeps): Move eslint peer deps to plugin-eslint package ([64d5708](spinnaker@64d5708)) chore(eslint-plugin): bump jest and lodash ([96b2b86](spinnaker@96b2b86)) feat(eslint-plugin): Add a new rule prefer-promise-like to help migrate off of ng.IPromise [spinnaker#8673](spinnaker#8673) ([3dc0309](spinnaker@3dc0309)) feat(eslint-plugin): Auto-fix arbitrary expressions with slashes in api-no-slashes lint rule ([28e95ee](spinnaker@28e95ee)) fix(eslint-plugin): Allow .split('/') in API.one() calls in api-no-slashes lint rule ([e547389](spinnaker@e547389)) fix(eslint-plugin): Cast a wider net in api-no-slashes.js [spinnaker#8649](spinnaker#8649) ([cf5ab83](spinnaker@cf5ab83)) feat(eslint-plugin): Write a new rule react2angular-with-error-boundary All react2angular components should be wrapped in an error boundary ([bd9858d](spinnaker@bd9858d)) refactor(eslint-plugin): move angular-rule utils to a separate directory ([873bec3](spinnaker@873bec3)) feat(eslint-plugin): Add a new rule api-no-slashes that forbids using string literals with slashes to API.one() [spinnaker#8629](spinnaker#8629) ([75a054e](spinnaker@75a054e)) feat(eslint-plugin): Add a README.md with instructions on creating eslint rules [spinnaker#8628](spinnaker#8628) ([6cab9e6](spinnaker@6cab9e6))
mergify bot
pushed a commit
that referenced
this pull request
Nov 10, 2020
fix(pluginsdk-peerdeps): Move eslint peer deps to plugin-eslint package ([64d5708](64d5708)) chore(eslint-plugin): bump jest and lodash ([96b2b86](96b2b86)) feat(eslint-plugin): Add a new rule prefer-promise-like to help migrate off of ng.IPromise [#8673](#8673) ([3dc0309](3dc0309)) feat(eslint-plugin): Auto-fix arbitrary expressions with slashes in api-no-slashes lint rule ([28e95ee](28e95ee)) fix(eslint-plugin): Allow .split('/') in API.one() calls in api-no-slashes lint rule ([e547389](e547389)) fix(eslint-plugin): Cast a wider net in api-no-slashes.js [#8649](#8649) ([cf5ab83](cf5ab83)) feat(eslint-plugin): Write a new rule react2angular-with-error-boundary All react2angular components should be wrapped in an error boundary ([bd9858d](bd9858d)) refactor(eslint-plugin): move angular-rule utils to a separate directory ([873bec3](873bec3)) feat(eslint-plugin): Add a new rule api-no-slashes that forbids using string literals with slashes to API.one() [#8629](#8629) ([75a054e](75a054e)) feat(eslint-plugin): Add a README.md with instructions on creating eslint rules [#8628](#8628) ([6cab9e6](6cab9e6))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this out as an eslint rule to give plugin authors a chance to fix their code before we flip the new
APIencoding on.This is first pass at this rule and it doesn't detect literals passed in as variables. Also it probably wont pass CI, heh. I'm going to run this on the OSS repo and see what happens.