-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): eslint --fix api-no-slashes #8631
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherthielen
requested review from
vigneshm,
caseyhebebrand and
german-muzquiz
October 6, 2020 23:54
return results && results.length ? results[0] : null; | ||
}, | ||
function() { | ||
function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 Is this because of a new version of prettier
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. I have noticed this and some mods to one param arrow functions as well.
christopherthielen
force-pushed
the
api-no-slashes
branch
from
October 6, 2020 23:58
b03fd10
to
02b1b5b
Compare
caseyhebebrand
approved these changes
Oct 7, 2020
aravindmd
added a commit
that referenced
this pull request
Oct 9, 2020
aravindmd
added a commit
that referenced
this pull request
Oct 9, 2020
aravindmd
added a commit
that referenced
this pull request
Oct 9, 2020
mergify bot
pushed a commit
that referenced
this pull request
Oct 9, 2020
….0.518 docker 0.0.62 google 0.0.23 oracle 0.0.11 tencentcloud 0.0.8 titus 0.0.147 (#8640) * chore(amazon): publish amazon@0.0.271 3fd31ff fix(amazon/serverGroup): Additional null safety for networkInterfaces (#8638) fab1a0a chore(eslint): eslint --fix api-no-slashes (#8631) * chore(azure): publish azure@0.0.257 fab1a0a chore(eslint): eslint --fix api-no-slashes (#8631) * chore(cloudfoundry): publish cloudfoundry@0.0.103 fab1a0a chore(eslint): eslint --fix api-no-slashes (#8631) * chore(core): publish core@0.0.518 d565b00 Drag n drop nav (#8626) fab1a0a chore(eslint): eslint --fix api-no-slashes (#8631) * chore(docker): publish docker@0.0.62 fab1a0a chore(eslint): eslint --fix api-no-slashes (#8631) * chore(google): publish google@0.0.23 b221157 feat(gce): remove the deprecated ONLY_UP autoscaling mode (#8633) fab1a0a chore(eslint): eslint --fix api-no-slashes (#8631) * chore(oracle): publish oracle@0.0.11 fab1a0a chore(eslint): eslint --fix api-no-slashes (#8631) * chore(tencentcloud): publish tencentcloud@0.0.8 fab1a0a chore(eslint): eslint --fix api-no-slashes (#8631) * chore(titus): publish titus@0.0.147 ae43322 feat(titus): Add monitored deploy strategy support to titus (#8596)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies the auto-fixes for new
api-no-slashes
eslint rule from #8629Duplicates work originally done in #8586
via:
eslint --fix