-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency. #8665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in deck microservice to remove Halyard dependency.
anupmpatil
changed the title
@anupmpatil fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency.
fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency.
Oct 19, 2020
@christopherthielen could you please help us with this PR to review and get merged? |
christopherthielen
approved these changes
Oct 20, 2020
christopherthielen
added a commit
that referenced
this pull request
Oct 26, 2020
1e2032b chore(PromiseLike): Migrate code from IPromise types to PromiseLike 553be66 chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports c9c0b4d feat($q): Adds PromiseLike compatibility to $q and $q promises 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) f3e1d6e fix(core): Check if manifest event is null from k8s. (#8666) 6022821 fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency. (#8665) 926b1bd feat(core/managed): run commit messages through Markdown (#8664)
christopherthielen
added a commit
that referenced
this pull request
Oct 26, 2020
e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) 6022821 fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency. (#8665)
christopherthielen
added a commit
that referenced
this pull request
Oct 26, 2020
1e2032b chore(PromiseLike): Migrate code from IPromise types to PromiseLike 553be66 chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports c9c0b4d feat($q): Adds PromiseLike compatibility to $q and $q promises 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) f3e1d6e fix(core): Check if manifest event is null from k8s. (#8666) 6022821 fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency. (#8665) 926b1bd feat(core/managed): run commit messages through Markdown (#8664)
christopherthielen
added a commit
that referenced
this pull request
Oct 26, 2020
e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) 6022821 fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency. (#8665)
christopherthielen
added a commit
that referenced
this pull request
Oct 26, 2020
0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) 343296b chore(core): publish core@0.0.522 1e2032b chore(PromiseLike): Migrate code from IPromise types to PromiseLike 553be66 chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports c9c0b4d feat($q): Adds PromiseLike compatibility to $q and $q promises 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) f3e1d6e fix(core): Check if manifest event is null from k8s. (#8666) 6022821 fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency. (#8665) 926b1bd feat(core/managed): run commit messages through Markdown (#8664)
christopherthielen
added a commit
that referenced
this pull request
Oct 26, 2020
0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) e083d75 chore(oracle): publish oracle@0.0.14 e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) 6022821 fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency. (#8665)
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2020
…undry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149 (#8680) * chore(amazon): publish amazon@0.0.274 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) 602021d chore(amazon): publish amazon@0.0.274 d5ae512 chore(PromiseLike): Migrate code from IPromise types to PromiseLike 553be66 chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) * chore(appengine): publish appengine@0.0.21 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) dad138d chore(appengine): publish appengine@0.0.21 d5ae512 chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) * chore(azure): publish azure@0.0.259 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) 7852568 chore(azure): publish azure@0.0.259 e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) * chore(cloudfoundry): publish cloudfoundry@0.0.105 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) 6d4e22c chore(cloudfoundry): publish cloudfoundry@0.0.105 d5ae512 chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) * chore(core): publish core@0.0.522 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) 343296b chore(core): publish core@0.0.522 1e2032b chore(PromiseLike): Migrate code from IPromise types to PromiseLike 553be66 chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports c9c0b4d feat($q): Adds PromiseLike compatibility to $q and $q promises 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) f3e1d6e fix(core): Check if manifest event is null from k8s. (#8666) 6022821 fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency. (#8665) 926b1bd feat(core/managed): run commit messages through Markdown (#8664) * chore(docker): publish docker@0.0.64 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) 3207ad0 chore(docker): publish docker@0.0.64 553be66 chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) * chore(ecs): publish ecs@0.0.267 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) a7dc7e5 chore(ecs): publish ecs@0.0.267 e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) * chore(google): publish google@0.0.25 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) 6ccd3bd chore(google): publish google@0.0.25 1e2032b chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) * chore(huaweicloud): publish huaweicloud@0.0.7 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) c7279a2 chore(huaweicloud): publish huaweicloud@0.0.7 e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) * chore(kubernetes): publish kubernetes@0.0.53 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) 450e7cb chore(kubernetes): publish kubernetes@0.0.53 553be66 chore(PromiseLike): Migrate code from IPromise types to PromiseLike e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) 67c0d3d fix(kubernetes): remove unneeded application validation warning (#8662) * chore(oracle): publish oracle@0.0.14 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) e083d75 chore(oracle): publish oracle@0.0.14 e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) 6022821 fix(deck): Bugfix 6112: provide default settings for oracle provider in deck microservice to remove Halyard dependency. (#8665) * chore(tencentcloud): publish tencentcloud@0.0.10 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) 10b8d86 chore(tencentcloud): publish tencentcloud@0.0.10 e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668) * chore(titus): publish titus@0.0.149 0b1e297 chore(modules): Reformat package.json with prettier (#8679) a220af5 Revert "chore(package): amazon@0.0.274 appengine@0.0.21 azure@0.0.259 cloudfoundry@0.0.105 core@0.0.522 docker@0.0.64 ecs@0.0.267 google@0.0.25 huaweicloud@0.0.7 kubernetes@0.0.53 oracle@0.0.14 tencentcloud@0.0.10 titus@0.0.149" (#8678) f41283f chore(titus): publish titus@0.0.149 e622a53 feat(typescript): Add a new `app/types` typeRoot to all the tsconfig.json files providing `PromiseLike` and *.svg imports 8b3c134 chore(package): In packages, do not use webpack to typecheck (#8670) 231f781 chore(package): use node_modules/.bin/* in module scripts, add 'build' script (the old 'lib' script) (#8668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(deck): settings.js doesn't have Oracle default settings
Since the Halyard is planned to sunset, as suggested by @maggieneterval we are moving the config defaults into the microservices themselves rather than have Halyard supply them.