Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): rename capacityProviderStrategies to capacityProviderStrategy #8784

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

allisaurus
Copy link
Contributor

@allisaurus allisaurus commented Dec 11, 2020

Rename capacityProviderStrategies to capacityProviderStrategy to align with CreateService api. As this is a new feature for 1.24, this will not be backwards incompatible if patched.

Testing

  • UI screenshot
    image

  • update JSON for stage
    image

  • deployment success
    image

Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 💯 I love that you didn't have to change the functional test because of the test data id 😄

@allisaurus allisaurus added the Do Not Merge Don't merge yet label Dec 11, 2020
@allisaurus
Copy link
Contributor Author

CC @fieldju re: cherry-picking this to 1.24.x

@fieldju fieldju removed the Do Not Merge Don't merge yet label Dec 11, 2020
@fieldju fieldju merged commit d9a2a81 into spinnaker:master Dec 11, 2020
@fieldju
Copy link
Contributor

fieldju commented Dec 11, 2020

@Mergifyio backport release-1.24.x

@mergify
Copy link
Contributor

mergify bot commented Dec 11, 2020

Command backport release-1.24.x: success

Backports have been created

fieldju added a commit that referenced this pull request Dec 11, 2020
…8784

fix(ecs): rename capacityProviderStrategies to capacityProviderStrategy (bp #8784)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants