New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(md): waiting status #8836
feat(md): waiting status #8836
Conversation
5b352ac
to
8a7835a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing this!
<b>Waiting for information.</b> | ||
</p> | ||
<p> | ||
This resource is part of a brand new environment. We are waiting for an artifact to become available to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer contractions where possible as it reads more conversational vs. formal
This resource is part of a brand new environment. We are waiting for an artifact to become available to | |
This resource is part of a brand new environment. We're waiting for an artifact to become available to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looking back at the content of these status messages I'd suggest using Spinnaker is...
to be consistent, we haven't yet deviated from that pattern in MD microcopy. Sorry for the thrash between suggestions.
This resource is part of a brand new environment. We are waiting for an artifact to become available to | |
This resource is part of a brand new environment. Spinnaker is waiting for an artifact to become available to |
8a7835a
to
367ac7f
Compare
95eacfb refactor(core/deployment): Update redblack fields without force updating (#8840) a027d62 fix(gitlab): fix help text for gitlab artifacts 8858746 feat(md): waiting status (#8836) c7eb9f4 feat(kubernetes): Raw resources UI MVP (#8800) ef87a9e fix(core/executions): Update migrated status to match API (#8831) 3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog) 8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys c32c91a fix(serverGroup): Increase the timeout for api request (#8812) 29a85a0 feat(core/executions): Render newly migrated execution groups (#8807) 8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (#8806)
95eacfb refactor(core/deployment): Update redblack fields without force updating (#8840) a027d62 fix(gitlab): fix help text for gitlab artifacts 8858746 feat(md): waiting status (#8836) c7eb9f4 feat(kubernetes): Raw resources UI MVP (#8800) ef87a9e fix(core/executions): Update migrated status to match API (#8831) 3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog) 8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys c32c91a fix(serverGroup): Increase the timeout for api request (#8812) 29a85a0 feat(core/executions): Render newly migrated execution groups (#8807) 8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (#8806)
95eacfb refactor(core/deployment): Update redblack fields without force updating (spinnaker#8840) a027d62 fix(gitlab): fix help text for gitlab artifacts 8858746 feat(md): waiting status (spinnaker#8836) c7eb9f4 feat(kubernetes): Raw resources UI MVP (spinnaker#8800) ef87a9e fix(core/executions): Update migrated status to match API (spinnaker#8831) 3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog) 8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys c32c91a fix(serverGroup): Increase the timeout for api request (spinnaker#8812) 29a85a0 feat(core/executions): Render newly migrated execution groups (spinnaker#8807) 8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (spinnaker#8806)
Adding a new status that denotes a new environment waiting for an artifact to become available.