refactor(core/deployment): Update redblack fields without force updating #8840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyhebebrand
commented
Jan 12, 2021
Comment on lines
-14
to
-17
| private handleChange = (key: string, value: any) => { | ||
| set(this.props.command, key, value); | ||
| this.forceUpdate(); | ||
| }; |
There was a problem hiding this comment.
This is the main thing I wanted to get rid of, but it gets lost in the refactor. Now, the field onChange just directly uses the onChange prop.
vigneshm
approved these changes
Jan 12, 2021
vigneshm
added a commit
that referenced
this pull request
Jan 13, 2021
vigneshm
added a commit
that referenced
this pull request
Jan 13, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (#8840) a027d62 fix(gitlab): fix help text for gitlab artifacts 8858746 feat(md): waiting status (#8836) c7eb9f4 feat(kubernetes): Raw resources UI MVP (#8800) ef87a9e fix(core/executions): Update migrated status to match API (#8831) 3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog) 8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys c32c91a fix(serverGroup): Increase the timeout for api request (#8812) 29a85a0 feat(core/executions): Render newly migrated execution groups (#8807) 8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (#8806)
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (#8840) a027d62 fix(gitlab): fix help text for gitlab artifacts 8858746 feat(md): waiting status (#8836) c7eb9f4 feat(kubernetes): Raw resources UI MVP (#8800) ef87a9e fix(core/executions): Update migrated status to match API (#8831) 3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog) 8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys c32c91a fix(serverGroup): Increase the timeout for api request (#8812) 29a85a0 feat(core/executions): Render newly migrated execution groups (#8807) 8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (#8806)
paragbhingre
pushed a commit
to paragbhingre/deck
that referenced
this pull request
Jan 21, 2021
…ing (spinnaker#8840) * refactor(core/deployment): Update redblack fields without force updating * refactor(cloudfoundry): Remove duplicate redblack additional fields component
paragbhingre
pushed a commit
to paragbhingre/deck
that referenced
this pull request
Jan 21, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (spinnaker#8840) 84b5920 feat(cloudfoundry): Simplification (spinnaker#8826) a486688 feat(cloudfoundry): add create service binding stage (spinnaker#8823)
paragbhingre
pushed a commit
to paragbhingre/deck
that referenced
this pull request
Jan 21, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (spinnaker#8840) a027d62 fix(gitlab): fix help text for gitlab artifacts 8858746 feat(md): waiting status (spinnaker#8836) c7eb9f4 feat(kubernetes): Raw resources UI MVP (spinnaker#8800) ef87a9e fix(core/executions): Update migrated status to match API (spinnaker#8831) 3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog) 8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys c32c91a fix(serverGroup): Increase the timeout for api request (spinnaker#8812) 29a85a0 feat(core/executions): Render newly migrated execution groups (spinnaker#8807) 8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (spinnaker#8806)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onChangeprop that is already passed in. This helps with reusing this component when the command originates from a react component.