Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core/executions): Render newly migrated execution groups #8807

Merged

Conversation

caseyhebebrand
Copy link
Contributor

@caseyhebebrand caseyhebebrand commented Dec 17, 2020

  • Add optional migrationStatus to IPipeline
  • Add an in-migration class to add unique styling to the newly migrated execution group
  • Sort newly migrated groups to the top of the list
  • A generic migration tag component, that can be overriden with a migration-specific component if needed

Screen Shot 2020-12-16 at 9 08 57 PM

@@ -291,7 +293,10 @@ export class ExecutionGroup extends React.PureComponent<IExecutionGroupProps, IE
<div className="clickable sticky-header" onClick={this.handleHeadingClicked}>
<div className={`execution-group-heading ${pipelineDisabled ? 'inactive' : 'active'}`}>
<span className={`glyphicon pipeline-toggle glyphicon-chevron-${this.state.open ? 'down' : 'right'}`} />
<div className="shadowed" style={{ position: 'relative' }}>
<div
className={`shadowed ${pipelineJustMigrated ? 'in-migration' : ''}`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classnames utility would make these read better.

@caseyhebebrand caseyhebebrand merged commit 29a85a0 into spinnaker:master Dec 18, 2020
@caseyhebebrand caseyhebebrand deleted the migrated-execution-group branch December 18, 2020 18:54
vigneshm added a commit that referenced this pull request Jan 13, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (#8840)
a027d62 fix(gitlab): fix help text for gitlab artifacts
8858746 feat(md): waiting status (#8836)
c7eb9f4 feat(kubernetes): Raw resources UI MVP (#8800)
ef87a9e fix(core/executions): Update migrated status to match API (#8831)
3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog)
8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys
c32c91a fix(serverGroup): Increase the timeout for api request (#8812)
29a85a0 feat(core/executions): Render newly migrated execution groups  (#8807)
8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (#8806)
mergify bot pushed a commit that referenced this pull request Jan 13, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (#8840)
a027d62 fix(gitlab): fix help text for gitlab artifacts
8858746 feat(md): waiting status (#8836)
c7eb9f4 feat(kubernetes): Raw resources UI MVP (#8800)
ef87a9e fix(core/executions): Update migrated status to match API (#8831)
3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog)
8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys
c32c91a fix(serverGroup): Increase the timeout for api request (#8812)
29a85a0 feat(core/executions): Render newly migrated execution groups  (#8807)
8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (#8806)
paragbhingre pushed a commit to paragbhingre/deck that referenced this pull request Jan 21, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (spinnaker#8840)
a027d62 fix(gitlab): fix help text for gitlab artifacts
8858746 feat(md): waiting status (spinnaker#8836)
c7eb9f4 feat(kubernetes): Raw resources UI MVP (spinnaker#8800)
ef87a9e fix(core/executions): Update migrated status to match API (spinnaker#8831)
3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog)
8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys
c32c91a fix(serverGroup): Increase the timeout for api request (spinnaker#8812)
29a85a0 feat(core/executions): Render newly migrated execution groups  (spinnaker#8807)
8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (spinnaker#8806)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants