-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/executions): Render newly migrated execution groups #8807
Merged
caseyhebebrand
merged 3 commits into
spinnaker:master
from
caseyhebebrand:migrated-execution-group
Dec 18, 2020
Merged
feat(core/executions): Render newly migrated execution groups #8807
caseyhebebrand
merged 3 commits into
spinnaker:master
from
caseyhebebrand:migrated-execution-group
Dec 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyhebebrand
requested review from
christopherthielen,
alanmquach and
vigneshm
December 17, 2020 17:26
vigneshm
approved these changes
Dec 18, 2020
@@ -291,7 +293,10 @@ export class ExecutionGroup extends React.PureComponent<IExecutionGroupProps, IE | |||
<div className="clickable sticky-header" onClick={this.handleHeadingClicked}> | |||
<div className={`execution-group-heading ${pipelineDisabled ? 'inactive' : 'active'}`}> | |||
<span className={`glyphicon pipeline-toggle glyphicon-chevron-${this.state.open ? 'down' : 'right'}`} /> | |||
<div className="shadowed" style={{ position: 'relative' }}> | |||
<div | |||
className={`shadowed ${pipelineJustMigrated ? 'in-migration' : ''}`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
classnames
utility would make these read better.
caseyhebebrand
force-pushed
the
migrated-execution-group
branch
from
December 18, 2020 18:38
af723e3
to
ad8fdc4
Compare
vigneshm
added a commit
that referenced
this pull request
Jan 13, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (#8840) a027d62 fix(gitlab): fix help text for gitlab artifacts 8858746 feat(md): waiting status (#8836) c7eb9f4 feat(kubernetes): Raw resources UI MVP (#8800) ef87a9e fix(core/executions): Update migrated status to match API (#8831) 3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog) 8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys c32c91a fix(serverGroup): Increase the timeout for api request (#8812) 29a85a0 feat(core/executions): Render newly migrated execution groups (#8807) 8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (#8806)
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (#8840) a027d62 fix(gitlab): fix help text for gitlab artifacts 8858746 feat(md): waiting status (#8836) c7eb9f4 feat(kubernetes): Raw resources UI MVP (#8800) ef87a9e fix(core/executions): Update migrated status to match API (#8831) 3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog) 8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys c32c91a fix(serverGroup): Increase the timeout for api request (#8812) 29a85a0 feat(core/executions): Render newly migrated execution groups (#8807) 8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (#8806)
paragbhingre
pushed a commit
to paragbhingre/deck
that referenced
this pull request
Jan 21, 2021
95eacfb refactor(core/deployment): Update redblack fields without force updating (spinnaker#8840) a027d62 fix(gitlab): fix help text for gitlab artifacts 8858746 feat(md): waiting status (spinnaker#8836) c7eb9f4 feat(kubernetes): Raw resources UI MVP (spinnaker#8800) ef87a9e fix(core/executions): Update migrated status to match API (spinnaker#8831) 3a51af2 fix(core/deploymentStrategy): do not show highlander preview in deploy stage config (only show in clone dialog) 8be06a0 feat(core/deploymentStrategy): Add a preview for Highlander deploys c32c91a fix(serverGroup): Increase the timeout for api request (spinnaker#8812) 29a85a0 feat(core/executions): Render newly migrated execution groups (spinnaker#8807) 8f291c0 fix(core/projects): Fix duplicate Projects appearing in recent history (on search screen) (spinnaker#8806)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrationStatus
toIPipeline
in-migration
class to add unique styling to the newly migrated execution group