Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfoundry): support docker deployments on cloudfoundry #8864

Merged
merged 4 commits into from
Feb 8, 2021

Conversation

zachsmith1
Copy link
Contributor

@zachsmith1 zachsmith1 commented Jan 22, 2021

We are enabling deployments for docker images in cloudfoundry. In order to do this, we need a user to be able to select a docker image artifact type from the dropdown thats provided during configuration.

spinnaker/clouddriver#5208

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

Copy link
Member

@kevinawoo kevinawoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this when the Clouddriver PR is ready

@german-muzquiz german-muzquiz added the ready to merge Reviewed and ready for merge label Feb 8, 2021
@mergify mergify bot merged commit 5713c91 into spinnaker:master Feb 8, 2021
caseyhebebrand added a commit that referenced this pull request Feb 8, 2021
5713c91 feat(cloudfoundry): support docker deployments on cloudfoundry (#8864)
mergify bot pushed a commit that referenced this pull request Feb 8, 2021
5713c91 feat(cloudfoundry): support docker deployments on cloudfoundry (#8864)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Reviewed and ready for merge target-release/1.25
Projects
None yet
4 participants