single UI view for insight #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -219,7 +219,6 @@ dl { | |||
| border: 1px solid #aaaaaa; | |||
| background-color: #ffffff; | |||
| min-height: 500px; | |||
| margin-left: 20px; | |||
There was a problem hiding this comment.
I don't think we should be modifying the margin of a grid element. Rather, we should use the col-md div as a wrapper around another div and modifying the padding details-panel.
There was a problem hiding this comment.
Agreed - this was causing problems elsewhere; thought I had cleared it out but I guess not.
|
I don't see the |
|
PR updated. add -p too hard. |
| </div> | ||
| </div> | ||
| <div class="col-md-4 details-panel"> | ||
| <div class="header"> |
There was a problem hiding this comment.
I think this should all be replaced with <div ui-view="detail"></div>; otherwise, looks good.
anotherchrisberry
pushed a commit
that referenced
this pull request
Feb 24, 2016
Merge changes from upstream deck
bfarrell
added a commit
to bfarrell/deck
that referenced
this pull request
Jun 10, 2016
Merged
clanesf
added a commit
to clanesf/deck
that referenced
this pull request
Oct 2, 2019
This was referenced Oct 25, 2019
Closed
Closed
fieldju
pushed a commit
to armory/deck
that referenced
this pull request
Jun 5, 2020
This was referenced Oct 30, 2020
rvazquezglez
pushed a commit
to rvazquezglez/deck
that referenced
this pull request
Jan 5, 2021
thameezb
pushed a commit
to thameezb/deck
that referenced
this pull request
May 26, 2023
add igor * add igor * remove commented lines Approved-by: Salvatore Mazzarino
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes
Adds an abstract state named
insightand a corresponding view. All of the cluster, elb, asg and security groups states are children ofinsight.reason
This gives us a lot greater flexibility with how to display data in the application view. Previously, the
nav,masteranddetailsviews were hardcoded into the application template, forcing a specific presentation of data. In particular,tasksdoes not fit well into this style.