Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudfoundry): support docker deployments #5208

Merged
merged 4 commits into from
Feb 3, 2021
Merged

feat(cloudfoundry): support docker deployments #5208

merged 4 commits into from
Feb 3, 2021

Conversation

zachsmith1
Copy link
Contributor

@zachsmith1 zachsmith1 commented Jan 26, 2021

This change allows docker artifacts to be deployed to cloudfoundry. The original logic was constrained to deployments packages with types buildpack/bits. This was refactored so that packages can be independently created for either type. We also refactored the lifecycle object so that it can be independently created for the docker or buildpack lifecycle. Tests were added and adjusted to cover the new logic and support the existing logic in place.

spinnaker/deck#8864

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@zachsmith1 zachsmith1 marked this pull request as ready for review January 28, 2021 18:11
@zachsmith1
Copy link
Contributor Author

zachsmith1 commented Jan 28, 2021

Fixes -> spinnaker/spinnaker#6191

@kevinawoo kevinawoo merged commit 6d77230 into spinnaker:master Feb 3, 2021
@zachsmith1 zachsmith1 deleted the feat/migrateToV2AppsCF branch February 3, 2021 18:29
EasyAsABC123 pushed a commit to EasyAsABC123/clouddriver that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants