fix(github): Put back github endpoint configuration (#726) (#731)

* fix(github): Put back github endpoint configuration

* Removed useless test

echo-notifications/src/main/groovy/com/netflix/spinnaker/echo/config/GithubConfig.java

@@ -19,6 +19,7 @@
 import com.netflix.spinnaker.echo.github.GithubService;
 import com.netflix.spinnaker.retrofit.Slf4jRetrofitLogger;
 import lombok.extern.slf4j.Slf4j;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
@@ -32,11 +33,12 @@
 @ConditionalOnProperty("github-status.enabled")
 @Slf4j
 public class GithubConfig {
-  static final String GITHUB_STATUS_URL = "https://api.github.com";
+
+  @Value("${github-status.endpoint:'https://api.github.com'}")
+  private String endpoint;
 
   @Bean
   public Endpoint githubEndpoint() {
-    String endpoint = GITHUB_STATUS_URL;
     return Endpoints.newFixedEndpoint(endpoint);
   }
 

echo-notifications/src/test/groovy/com/netflix/spinnaker/echo/config/GithubConfigSpec.groovy

@@ -0,0 +1,23 @@
+package com.netflix.spinnaker.echo.config
+
+import spock.lang.Specification
+import spock.lang.Subject
+import retrofit.Endpoint
+
+class GithubConfigSpec extends Specification {
+  @Subject
+  GithubConfig githubConfig = new GithubConfig()
+
+  def 'test github incoming endpoint is correctly setted'() {
+    given:
+    String ownEndpoint = "https://github.myendpoint.com"
+    githubConfig.endpoint = ownEndpoint;
+
+    when:
+    Endpoint endpoint = githubConfig.githubEndpoint()
+
+    then:
+    endpoint.url == ownEndpoint
+  }
+
+}