Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): fetch previous tag from git instead of API (backport #1181) #1183

Merged
merged 1 commit into from
Apr 27, 2022
Merged

fix(ci): fetch previous tag from git instead of API (backport #1181) #1183

merged 1 commit into from
Apr 27, 2022

Commits on Apr 27, 2022

  1. fix(ci): fetch previous tag from git instead of API (#1181) 

    Previously the release info script would query the GitHub HTTP API and retrieve
the latest "Release" (git tag) published.
The latest "Release" could (likely) be for a different `release-*` branch or
even `master` rather than the previous tag on the same branch as the new
tag.
This resulted in "Release" changelogs containing commits that dont
exist in the tags history.

By instead querying git itself we can fetch the previous tag in history
and then generate an accurate changelog, eg: between `v1.7.4` and
`v1.7.3` rather than potentially `v1.7.4` and `v1.10.0`.

Run script through `shellcheck` and `shfmt`.

(cherry picked from commit b2c7da2)
    @kskewes-sf
    kskewes-sf authored and mergify-bot committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    7307572 View commit details
    Browse the repository at this point in the history