Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tests): convert junit4 based testcases to junit5 and clean up in echo #1311

Merged
merged 1 commit into from
Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion echo-api-tck/echo-api-tck.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,5 @@ dependencies {
api("org.springframework.boot:spring-boot-starter-test")
api("dev.minutest:minutest")

testRuntimeOnly("org.junit.platform:junit-platform-launcher")
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine")
}
1 change: 0 additions & 1 deletion echo-pipelinetriggers/echo-pipelinetriggers.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,4 @@ dependencies {
testImplementation "org.assertj:assertj-core"

testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine"
testRuntimeOnly "org.junit.vintage:junit-vintage-engine"
}
1 change: 0 additions & 1 deletion echo-plugins-test/echo-plugins-test.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,5 @@ dependencies {
testImplementation("io.spinnaker.kork:kork-plugins")
testImplementation("io.spinnaker.kork:kork-plugins-tck")

testRuntimeOnly("org.junit.platform:junit-platform-launcher")
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine")
}
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import com.netflix.spinnaker.kork.proto.stats.CloudProvider
import com.netflix.spinnaker.kork.proto.stats.Event as StatsEvent
import com.netflix.spinnaker.kork.proto.stats.Execution
import com.netflix.spinnaker.kork.proto.stats.Status
import org.junit.Assume.assumeTrue
import org.junit.jupiter.api.Assumptions.assumeTrue
import org.junit.jupiter.api.Test
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.EnumSource
Expand Down
2 changes: 0 additions & 2 deletions echo-webhooks/echo-webhooks.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,4 @@ dependencies {
testImplementation "org.assertj:assertj-core"

testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine"
testRuntimeOnly "org.junit.platform:junit-platform-launcher"
testRuntimeOnly "org.junit.vintage:junit-vintage-engine"
}