Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gcb): Allow anonymous calls to igor #602

Merged
merged 1 commit into from
Jul 10, 2019
Merged

fix(gcb): Allow anonymous calls to igor #602

merged 1 commit into from
Jul 10, 2019

Conversation

ezimanyi
Copy link
Contributor

@ezimanyi ezimanyi commented Jul 9, 2019

Since the GCB functionality was written, we've started logging messages every time an intra-microservice call is anonymous. When calling igor in response to a PubSub message, we don't have any authentication context and need to make an anonymous call, so wrap these calls in an allowAnonymous call.

Since the GCB functionality was written, we've started logging
messages every time an intra-microservice call is anonymous.
When calling igor in response to a PubSub message, we don't have
any authentication context and need to make an anonymous call, so
wrap these calls in an allowAnonymous call.
@ezimanyi
Copy link
Contributor Author

ezimanyi commented Jul 9, 2019

This has no functional effect, it just removes some log messages.

Copy link
Contributor

@maggieneterval maggieneterval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵️‍♂️ ☎️

@ezimanyi ezimanyi merged commit fb5dd1d into spinnaker:master Jul 10, 2019
@ezimanyi ezimanyi deleted the remove-anonymous-logs branch July 10, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants