fix(error handling): mark executions failed #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a way to indicate failures in materializing a pipeline. If `echo` fails to materialize a pipeline during a trigger the failure needs to be recorded in `orca` otherwise the failure appears "silent" to the user because the UI is unable to show any errors unless they are associated with an execution. This is especially bad if, say, there is a typo in the properties file in the jenkins trigger Starting the pipeline appears to do nothing and the user is confused. This change captures errors during artifact resolution and sends them to `orca` to capture for the user >NOTE: depends on related `orca` PR: spinnaker/orca#3126
ezimanyi
approved these changes
Sep 3, 2019
| @@ -74,12 +74,17 @@ private void triggerMatchingPipelines(T event) { | |||
| try { | |||
| List<Pipeline> matchingPipelines = eventHandler.getMatchingPipelines(event, pipelineCache); | |||
| matchingPipelines.stream() | |||
| .filter(p -> p.getErrorMessage() == null) | |||
There was a problem hiding this comment.
Any thoughts on whether we should also allow the empty string through this filter? (And exclude it from the filter below?)
There was a problem hiding this comment.
was contemplating that myself and don't recall why i picked one over the other :)
but it's prob safer to isNullOrEmpty()it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a way to indicate failures in materializing a pipeline.
If
echofails to materialize a pipeline during a trigger the failure needs to be recordedin
orcaotherwise, the failure appears "silent" to the user because the UI is unable toshow any errors unless they are associated with an execution.
This is especially bad if, say, there is a typo in the properties file in the jenkins trigger
Starting the pipeline appears to do nothing and the user is confused.
This change captures errors during artifact resolution and sends them to
orcato capture for the user