feat(stats): Adds salt to application ID hash #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avram
approved these changes
Sep 25, 2019
ezimanyi
approved these changes
Sep 25, 2019
plumpy
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the application ID (which is an autogenerated-but-editable-by-the-user ULID) as a salt for application IDs.
The original design doc called for using the application creation time, but was pointed out that not all operations have this value, and that it doesn't really contain all that many bits of entropy. Using the instance ULID should solve both issues. Because the instance ID was actually being sent over the wire during an event, I changed to hash it as well.
Fixes spinnaker/spinnaker#4863