-
Notifications
You must be signed in to change notification settings - Fork 653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(triggers) Adds support for payloadConstraints on property files for build triggers #691
Conversation
I should probably add: I'm not a Java dev and this is my first time contributing to Spinnaker outside the spin cli. Feedback is very welcome |
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
This looks pretty reasonable. Can you add some unit testing around the constraint evaluation? |
@cfieber done! Let me know what you think, and if you want me to fix the incorrect commit messages. |
Thanks for this! |
@linjmeyer Thanks for this, this is awesome! |
Implements Spinnaker Issue #5053
Use case is conditionally triggering pipelines after a successful Jenkins build. For example, Jenkins may be setup for builds on all branches but Spinnaker pipelines should only be master. More complex use cases are possible too, like triggering 'stage' pipelines on feature/* branches or when a Jenkins build has something like
deploy_target=stage
.I think it will work with other build systems as long as they support properties, but unfortunately I don't have any available to test.