Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): Add new plugin trigger type #884

Merged
merged 2 commits into from
May 6, 2020

Conversation

robzienert
Copy link
Member

No description provided.

@robzienert robzienert requested a review from a team May 5, 2020 22:56
private String version;
private String releaseDate;
private List<Map<String, String>> requires;
private String binaryUrl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add the state field here?

String version;
String releaseDate;
List<Map<String, String>> requires;
String binaryUrl;
Copy link
Contributor

@jonsie jonsie May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

@robzienert robzienert added the ready to merge Approved and ready for merge label May 6, 2020
@mergify mergify bot added the auto merged label May 6, 2020
@mergify mergify bot merged commit 669a9f3 into spinnaker:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants