Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(roles): Allow anonymous calls from Fiat to other Spinnaker modules #479

Merged
merged 2 commits into from
Oct 18, 2019

Conversation

jervi
Copy link
Contributor

@jervi jervi commented Oct 3, 2019

Will suppress all the Request GET:http://<service>/<endpoint> is missing [X-SPINNAKER-USER, X-SPINNAKER-ACCOUNTS] authentication headers and will be treated as anonymous messages that is currently spamming the Fiat log.

@jervi jervi changed the title fix(roles): Allow anonymous calls from Igor to other Spinnaker modules fix(roles): Allow anonymous calls from Fiat to other Spinnaker modules Oct 3, 2019
Will suppress all the `Request GET:http://front50/serviceAccounts is missing [X-SPINNAKER-USER, X-SPINNAKER-ACCOUNTS] authentication headers and will be treated as anonymous` messages that is currently spamming the Fiat log.
@cfieber cfieber added the ready to merge Approved and ready for merge label Oct 17, 2019
@23doors
Copy link

23doors commented Oct 18, 2019

anything holding this back? would love to see it merged, these WARNs are kind of confusing

@cfieber cfieber merged commit 4afff61 into spinnaker:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Approved and ready for merge target-release/1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants