fix(dependency): Issue with jackson-bom and kotlin-bom version conflict resolution while upgrading the spring-boot 2.3.x #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct resolution while upgrading the spring-boot 2.3.x The root cause of this issue is uncontrolled conflict resolution of jackson-bom and kotlin-bom dependency version imported from external maven BOM provided by kork-bom, as per the gradle documentation here (https://docs.gradle.org/6.9.1/userguide/platforms.html#sub:bom_import), we can use gradle enforcedPlatform closure as part of the implementation to strictly adhere the versions of direct and transitive dependencies imported BOM. This approach could be considered as optimally feasible fix for this issue. And for upcoming upgrades and developments, it will also ensure the predictable dependency imports from kork-bom. Similar issue has been encountered while upgrading spring-boot to 2.3.x for gate service, for detailed discussion please refer to: spinnaker/gate#1505 This fix is seamless for the existing code.
dbyron-sf
approved these changes
Mar 10, 2022
11 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of this issue is uncontrolled conflict resolution of jackson-bom and kotlin-bom dependency version imported from external maven BOM provided by kork-bom, as per the gradle documentation here (https://docs.gradle.org/6.9.1/userguide/platforms.html#sub:bom_import), we can use gradle enforcedPlatform closure as part of the implementation to strictly adhere the versions of direct and transitive dependencies imported BOM. This approach could be considered as optimally feasible fix for this issue. And for upcoming upgrades and developments, it will also ensure the predictable dependency imports from kork-bom.
Similar issue has been encountered while upgrading spring-boot to 2.3.x for gate service, for detailed discussion please refer to:
spinnaker/gate#1505
This fix is seamless for the existing code.