-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dependency): Forcing oci-java-sdk-objectstorage version for desired conflict resolution. #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired conflict resolution. While enforcing the direct and transitive dependencies strictly from kork-bom using "enforcedPlatform" in build.gradle as: implementation(enforcedPlatform("io.spinnaker.kork:kork-bom:$korkVersion")) oci-java-sdk-bom:1.5.17 is overriding the oci-java-sdk-objectstorage:1.19.1 (transitive dependency) version, which is an older version coming from kork-bom mentioned in spinnaker-dependencies.gradle. It is causing an error in front50-oracle module as given below: > Task :front50-oracle:compileJava /home/ubuntu/spinnaker-comp/sb-upgrade-2-3-12/front50/front50-oracle/src/main/java/com/netflix/spinnaker/front50/model/OracleStorageService.java:232: error: cannot find symbol buildObjectKey(objectType, summary.getName()), summary.getTimeModified().getTime()); ^ symbol: method getTimeModified() location: variable summary of type ObjectSummary Note: /home/ubuntu/spinnaker-comp/sb-upgrade-2-3-12/front50/front50-oracle/src/main/java/com/netflix/spinnaker/front50/model/OracleStorageService.java uses unchecked or unsafe operations. Note: Recompile with -Xlint:unchecked for details. 1 error > Task :front50-oracle:compileJava FAILED FAILURE: Build failed with an exception. In order to fix, we require oci-java-sdk-objectstorage:1.19.1 to force restore. Forcing the specified version will take precedence during conflict resolution and provide desired version.
Dependency insight after applying "enforcedPlatform":
|
Dependency insight after applying "enforcedPlatform" and apply fix:
|
j-sandy
changed the title
fix(dependencies): Forcing oci-java-sdk-objectstorage version for desired conflict resolution.
fix(dependency): Forcing oci-java-sdk-objectstorage version for desired conflict resolution.
Feb 25, 2022
dbyron-sf
approved these changes
Feb 25, 2022
11 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While enforcing the direct and transitive dependencies strictly from kork-bom using "enforcedPlatform" in build.gradle as:
implementation(enforcedPlatform("io.spinnaker.kork:kork-bom:$korkVersion"))
oci-java-sdk-bom:1.5.17 is overriding the oci-java-sdk-objectstorage:1.19.1 (transitive dependency) version, which is an older version coming from kork-bom mentioned in spinnaker-dependencies.gradle.
It is causing an error in front50-oracle module as given below:
In order to fix, we require oci-java-sdk-objectstorage:1.19.1 to force restore.
Forcing the specified version will take precedence during conflict resolution and provide desired version.