feat(plugins): Plugin version pinning #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsie
reviewed
Apr 28, 2020
|
|
||
| @RestController | ||
| @RequestMapping("/pluginVersions") | ||
| public class PluginVersionController { |
There was a problem hiding this comment.
Do we need an endpoint for defining the "latest" versions for a service? I.E., in the case wherein the server group is unknown (because it has not been deployed yet) and we want to define the versions for that next server group.
There was a problem hiding this comment.
I don't think that would be an endpoint that falls in scope of this PR. We'll need ways to actuate the versions, but there's a lot more than just that endpoint involved in making the feature work - I'd rather tackle that when we get to the overall feature. WDYT?
|
I think we'll want to add a |
robzienert
force-pushed
the
plugin-version-pinning
branch
from
ad1f50c
to
d661548
Compare
Adds new metadata store for pinning plugin versions to a server group. This ensures a server group will continue to load the same plugins even through instance replacement on long-lived server groups. Metadata is regularly cleaned up, leaving the last N records for a particular cluster, by default leaving the last 10 (which is likely excessive).
robzienert
force-pushed
the
plugin-version-pinning
branch
from
d661548
to
c408fc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new metadata store for pinning plugin versions to a server group. This
ensures a server group will continue to load the same plugins even through
instance replacement on long-lived server groups.
Metadata is regularly cleaned up, leaving the last N records for a particular
cluster, by default leaving the last 10 (which is likely excessive).