Pass any 429's through without triggering any Hystrix events #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ajordens
commented
Dec 7, 2015
ajordens
commented
- Will be extracted out into kork-hystrix
|
I expect to pull this out into PTAL @spinnaker/netflix-reviewers |
| try { | ||
| return work() | ||
| } catch (RetrofitError error) { | ||
| throw UpstreamBadRequest.classifyError(error, [HttpStatus.TOO_MANY_REQUESTS.value()]) |
There was a problem hiding this comment.
why not just propagate any 4xx back to the caller since we generally don't have any smarts in this layer?
if I submit malformed JSON or ask for a missing resource that should come back out
There was a problem hiding this comment.
Was going to do that when I moved it to kork-hystrix but I've gone ahead and done it here now.
throw UpstreamBadRequest.classifyError(error, HttpStatus.values().findAll { it.is4xxClientError() }*.value() as Collection<Integer>)
- Will be extracted out into kork-hystrix
|
PR updated to propagate all 4xx (and not just 429) |
ajordens
added a commit
that referenced
this pull request
Dec 7, 2015
Pass any 429's through without triggering any Hystrix events
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.