Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(saml): Allow overriding maxAuthenticationAge #861

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

pieterza
Copy link
Contributor

The default maxAuthenticationAge is 7200 in upstream spring module.
This change allows configuring the maxAuthenticationAge as per any other SAMLSecurityConfigProperties entry.

Example gate-local.yaml:

saml:
  maxAuthenticationAge: 604800

This made by possible by the following stale PR, and replaces it:
#550

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 83acd58: Allow overriding maxAuthenticationAge

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@pieterza pieterza changed the title Feat(saml): Allow overriding maxAuthenticationAge fix(saml): Allow overriding maxAuthenticationAge Jul 19, 2019
@cfieber cfieber merged commit f5a76ad into spinnaker:master Jul 19, 2019
@pieterza pieterza deleted the saml-max-auth-age branch July 19, 2019 20:14
@eaceaser
Copy link

@spinnakerbot cherry-pick 1.15

@spinnakerbot
Copy link
Contributor

Cherry pick successful: #865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants