Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(oauth2): Add before filter to fix basic auth #899

Merged
merged 2 commits into from
Sep 13, 2019
Merged

fix(oauth2): Add before filter to fix basic auth #899

merged 2 commits into from
Sep 13, 2019

Conversation

griffin
Copy link
Contributor

@griffin griffin commented Sep 11, 2019

See #826

@spinnakerbot
Copy link
Contributor

The following commits need their title changed:

  • 810be4b: fix(oauth) Add before filter to fix basic auth

Please format your commit title into the form:

<type>(<scope>): <subject>, e.g. fix(kubernetes): address NPE in status check

This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here.

@griffin griffin changed the title fix(oauth) Add before filter to fix basic auth fix(oauth2): Add before filter to fix basic auth Sep 12, 2019
@cfieber cfieber merged commit 3069283 into spinnaker:master Sep 13, 2019
@benjaminws
Copy link

benjaminws commented Sep 17, 2019 •
edited
Loading

👋 Any chance we could get this back-ported to 1.16 and or 1.15? Seems to be broken since the oauth2 update. The change seems straightforward enough.

cc @emjburns @cfieber

@benjaminws
Copy link

Friendly bump on my previous comment :)

@emjburns @ezimanyi @cfieber

@ezimanyi
Copy link
Contributor

Seems reasonable to me to cherry-pick this given that it was a regression and is a localized fix.

@ezimanyi
Copy link
Contributor

@spinnakerbot 🍒 ⛏️ 1.16
@spinnakerbot 🍒 ⛏️ 1.15

@spinnakerbot
Copy link
Contributor

Cherry pick successful: #912

spinnakerbot pushed a commit that referenced this pull request Sep 27, 2019
@griffin
fix(oauth2): Add before filter to fix basic auth (#899)
ea5c10d
spinnakerbot pushed a commit that referenced this pull request Sep 27, 2019
@griffin
fix(oauth2): Add before filter to fix basic auth (#899)
454d1b1
@spinnakerbot
Copy link
Contributor

Cherry pick successful: #913

louisjimenez pushed a commit that referenced this pull request Sep 27, 2019
@spinnakerbot @louisjimenez
fix(oauth2): Add before filter to fix basic auth (#899) (#912)
2cdf6f9
louisjimenez pushed a commit that referenced this pull request Sep 27, 2019
@spinnakerbot @louisjimenez
fix(oauth2): Add before filter to fix basic auth (#899) (#913)
9dfb915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfieber cfieber cfieber approved these changes

Assignees
No one assigned
Labels
target-release/1.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@griffin @spinnakerbot @benjaminws @ezimanyi @cfieber