fix(#3268) Adds missing ldap config parameters managerDn managerPassw… #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following commits need their title changed: 5b6dc90: fix(#3268) Adds missing ldap config parameters managerDn managerPassword groupSearchBase Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
senare
force-pushed
the
master
branch
3 times, most recently
from
dc56e83
to
d10e842
Compare
|
Also related spinnaker/spinnaker#2570 ? |
stewchen
suggested changes
Oct 12, 2018
|
Can we get this resolved and merged down @stewchen? |
stewchen
approved these changes
Apr 11, 2019
…agerPassword groupSearchBase spinnaker/spinnaker#3268
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why didn't it get linked to ?
spinnaker/spinnaker#3268
Oki, I need to enable Ldap so trying to fix whats missing here
First time trying to contrib so some hints and tips be welcome, thanx in advance !
I think this should be easy and straight forward but I am still trying to figure out how to build and test all to verify this, but I am opening the PR early/now anyway to gather some feedback and help